Code review comment for lp:~skinny.moey/drizzle/drizzle-warnings-conversion

Revision history for this message
Brian Aker (brianaker) wrote :

> I changed short unsigned int -> uint16_t and unsigned long to uint32_t.
>
> I could use a little bit of direction on where I should use ptrdiff_t after
> some reading about it and looking at the changes I didnt see where it should
> be used.

An int should be a uint32_t and a long should go to a uint64_t (assuming all logic lined up).

Looking at st_tree, allocated should have been a uint64_t.

« Back to merge proposal