Merge lp:~sjr/kicad/buildsys into lp:kicad/product

[Simon Richter]

Buildsystem fix, allowing gcc to be recognized during the first build (i.e. when no cache file exists). Without this patch, the entire gcc specific section in CMakeLists is skipped.

[Wayne Stambaugh (stambaughw)]

Please clarify which "entire gcc specific section in CMakeLists" you talking about. I just did some quick testing and the

if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" )
endif()

section in the main CMakeLists.txt gets executed without this change.

review: Needs Information

[Simon Richter (sjr)]

Sorry, misremembered the problem (I've made that change ages ago).

It's not the entire section that is being skipped, but just the parts dealing with GXX_HAS_VISIBILITY_FLAG and GXX_HAS_VISIBILITY_INLINES_FLAG, so on first run it doesn't set these flags even if the compiler supports them.

That became noticeable when I added the LTO support in the "lto" branch, because I placed that inside the gcc section as well.

[Wayne Stambaugh (stambaughw)]

Thanks for the update. That makes more sense.

review: Approve

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2015-04-08 17:27:04 +0000
+++ CMakeLists.txt	2015-05-01 21:51:09 +0000
@@ -115,6 +115,11 @@
          "Location of KiCad data files." )
 endif()
 
+# Generate build system specific header file.
+include( PerformFeatureChecks )
+perform_feature_checks()
+
+
 #================================================
 # Set flags for GCC, or treat llvm as GCC
 #================================================
@@ -563,10 +568,6 @@
 # Include MinGW resource compiler.
 include( MinGWResourceCompiler )
 
-# Generate build system specific header file.
-include( PerformFeatureChecks )
-perform_feature_checks()
-
 # Find GDI+ on windows if wxGraphicsContext is available.
 if( MINGW AND USE_WX_GRAPHICS_CONTEXT )
     find_package( GdiPlus )