lp:~sjakthol/compiz/fix-749084

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:compiz/0.9.10 at revision 3758

PS Jenkins bot (community): Approve (continuous-integration) on 2013-07-09

MC Return: Approve on 2013-07-05

Diff: 942 lines (+360/-462)

2 files modified

plugins/dbus/src/dbus.cpp (+305/-461)
plugins/dbus/src/dbus.h (+55/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #749084: Regression: D-Bus Plugin's introspection stuff needs rewrite for 0.9.x as methods don't show up in dbus-tool (list method, plugin-metadata and introspection are broken)

Medium

Fix Released

Link a bug report

Related blueprints

3755. By Sami Jaktholm on 2013-07-04

Use prefix decrements and remove extra newline.

3754. By Sami Jaktholm on 2013-07-03

Port dbus introspection to compiz 0.9.
- move xml creation to a separate class (IntrospectionResponse) for easier
  memory management (allocate buffer and writer in ctor, free in dtor).
- move duplicated response sending code to a separate method that takes
  IntrospectionResponse and sends the resulting xml.
- Refactor handle*IntrospectMessage to work with compiz 0.9 interfaces.

This also fixes the broken list method which was a result of logic error. The
code to invoke list handler was never reached.

This fixes most of the issues noted in bug 749084.

3753. By MC Return on 2013-07-02

CCSM:
Fixed vertical alignment of the text on the stylized keys.
(Shift, Super, Ctrl, Alt)

(LP: #1196345). Fixes: https://bugs.launchpad.net/bugs/1196345.

Approved by Brandon Schaefer, PS Jenkins bot.

3752. By MC Return on 2013-07-02

Fixed broken text in all plugins (missing COMPIZ_TEXT_ABI).
(LP: #1196493). Fixes: https://bugs.launchpad.net/bugs/1196493.

Approved by Brandon Schaefer, PS Jenkins bot.

3751. By Sam Spilsbury on 2013-07-01

Unrevert 3728, fix failing tests.

Change the behaviour of undecorating windows.

Previously when a window was undecorated, we would shift it back to an appropriate position according to its gravity member. That behaviour was problematic because in the StaticGravity case the window has to just stay in the same place. But then if you had a window with StaticGravity which then did get a decoration and later removed it, it would be placed as though it was decorated and appear to be in the wrong place.

The correct behaviour is to place all windows as though they have decorations, and then when decorations are removed, to move the window back to the corner as indicated in its gravity and then expand its size to cover the obscured regions no longer hidden because the decorations went away.

(LP: #1165343).

  1. Completely remove decorOffsetMove and other related code from
     decor.cpp. Put the logic to handle the window->input () - window->border ()
     placement offset inside of setWindowFrameExtents instead. Now the window
     will always be offset from its original non-decorated position to the new
     decorated position, rather than having to guess between decoration sizes.
  2. Make saveGeometry and restoreGeometry work relative to window->border ()
     as opposed to including it in the saved geometry. It is possible that the
     border size might change during maximization, as such, we don't want to
     save the position with the border before maximizing. Instead save the position
     as if it were never decorated so that when the window is restored it can be
     restored to its original position and then adjusted for its new border size.
  3. Fix a few typoes in the tests.
  4. Moved some commonly used matchers into compiz::testing
  5. Make COMPIZ_PLUGIN_DIR accept multiple directories and look in each one
     of them for the plugin
  6. Set COMPIZ_PLUGIN_DIR appropriately for each plugin that we wish to load
     on startup so that we load locally built plugins as opposed to installed
     ones.
  7. Uncomment compiz_discover_tests for the acceptance tests. Now they are
     run by default.

(LP: #1195522). Fixes: https://bugs.launchpad.net/bugs/1195522.

Approved by PS Jenkins bot, MC Return, Brandon Schaefer.

3750. By MC Return on 2013-06-28

Expo:
Simplified the GL filter handling.

Approved by PS Jenkins bot, Sam Spilsbury.

3749. By MC Return on 2013-06-28

Mousepoll:
Fixed mousepoll version mismatch.
(COMPIZ_MOUSEPOLL_ABI was missing)

(LP: #1195659). Fixes: https://bugs.launchpad.net/bugs/1195659.

Approved by PS Jenkins bot, Łukasz Zemczak.

3748. By MC Return on 2013-06-28

Added contribute directory.
Added QtCreatorConfig.xml, a configuration file for Qt Creator, which
adjusts Qt Creator's C++ indentation style to be the same that is used
in the Compiz project (X11, mixed spaces and tabs).

Approved by PS Jenkins bot, MC Return.

3747. By MC Return on 2013-06-27

Expo, .xml.in fixes:

Better description of the plugin.
Improved and fixed tooltips.
Moved the "Curve Strength" option closer to "Deformation".

Refreshed the quilt patch for Ubuntu:
There is no need to set the default distance to 0.005 as this setting
has no effect without deformation.
Set default multi-screen mode to "One wall per output" for Ubuntu,
because "One big wall" works now for all display configurations and
could potentially change the appearance for Ubuntu users.

(LP: #1074487). Fixes: https://bugs.launchpad.net/bugs/1074487.

Approved by Didier Roche, PS Jenkins bot.

3746. By MC Return on 2013-06-26

Compiz, redundant and outdated files cleanup:

Removed outdated NEWS files.
Removed outdated AUTHORS and ChangeLog files.
Removed plugins/freewins/COPYING - we do not need another copy of the GPL v2 here.
Removed another copy of the GPL v2 from plugins/workarounds.

This will reduce package sizes, download time and bring some order to chaos.

Approved by Didier Roche, PS Jenkins bot, Sam Spilsbury.