Merge lp:~siretart/lightdm/fix.877766 into lp:ubuntu/oneiric-updates/lightdm

Proposed by Reinhard Tartler
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~siretart/lightdm/fix.877766
Merge into: lp:ubuntu/oneiric-updates/lightdm
Diff against target: 70 lines (+42/-0)
4 files modified
.bzrignore (+1/-0)
debian/changelog (+9/-0)
debian/patches/07_fix_877766.patch (+31/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~siretart/lightdm/fix.877766
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+95964@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added file '.bzrignore'
--- .bzrignore 1970-01-01 00:00:00 +0000
+++ .bzrignore 2012-03-05 18:12:21 +0000
@@ -0,0 +1,1 @@
1.pc
02
=== modified file 'debian/changelog'
--- debian/changelog 2012-03-04 19:29:04 +0000
+++ debian/changelog 2012-03-05 18:12:21 +0000
@@ -1,3 +1,12 @@
1lightdm (1.0.6-0ubuntu1.5) oneiric-proposed; urgency=low
2
3 * During the login process, make sure to first drop priviledges before
4 changing to the users home directory. On machines that have user homes
5 mounted with the option 'root_squash', the root user may not have
6 permissions and the chdir(1) syscall fails. LP: #877766.
7
8 -- Reinhard Tartler <siretart@tauware.de> Fri, 02 Mar 2012 15:04:34 +0100
9
1lightdm (1.0.6-0ubuntu1.4) oneiric-security; urgency=low10lightdm (1.0.6-0ubuntu1.4) oneiric-security; urgency=low
211
3 * SECURITY UPDATE: file descriptor leak to child processes (LP: #927060)12 * SECURITY UPDATE: file descriptor leak to child processes (LP: #927060)
413
=== added file 'debian/patches/07_fix_877766.patch'
--- debian/patches/07_fix_877766.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/07_fix_877766.patch 2012-03-05 18:12:21 +0000
@@ -0,0 +1,31 @@
1=== modified file 'src/session.c'
2--- a/src/session.c
3+++ b/src/session.c
4@@ -400,13 +400,6 @@ session_run (Process *process)
5
6 user = pam_session_get_user (session->priv->authentication);
7
8- /* Change working directory */
9- if (chdir (user_get_home_directory (user)) != 0)
10- {
11- g_warning ("Failed to change to home directory %s: %s", user_get_home_directory (user), strerror (errno));
12- _exit (EXIT_FAILURE);
13- }
14-
15 /* Change to this user */
16 if (getuid () == 0)
17 {
18@@ -429,6 +422,13 @@ session_run (Process *process)
19 }
20 }
21
22+ /* Change working directory */
23+ if (chdir (user_get_home_directory (user)) != 0)
24+ {
25+ g_warning ("Failed to change to home directory %s: %s", user_get_home_directory (user), strerror (errno));
26+ _exit (EXIT_FAILURE);
27+ }
28+
29 /* Redirect output to logfile */
30 if (session->priv->log_file_as_user)
31 setup_log_file (session);
032
=== modified file 'debian/patches/series'
--- debian/patches/series 2012-03-04 19:29:04 +0000
+++ debian/patches/series 2012-03-05 18:12:21 +0000
@@ -4,6 +4,7 @@
404_CVE-2011-4105.patch404_CVE-2011-4105.patch
505_CVE-2011-3153.patch505_CVE-2011-3153.patch
606_translate_prompt_label.patch606_translate_prompt_label.patch
707_fix_877766.patch
709_show_lang_chooser_option.patch809_show_lang_chooser_option.patch
810_available_languages.patch910_available_languages.patch
911_set_language_in_accountsservice.patch1011_set_language_in_accountsservice.patch

Subscribers

People subscribed via source and target branches