Merge lp:~siretart/lightdm/fix.877766 into lp:ubuntu/oneiric-updates/lightdm

Proposed by Reinhard Tartler
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~siretart/lightdm/fix.877766
Merge into: lp:ubuntu/oneiric-updates/lightdm
Diff against target: 70 lines (+42/-0)
4 files modified
.bzrignore (+1/-0)
debian/changelog (+9/-0)
debian/patches/07_fix_877766.patch (+31/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~siretart/lightdm/fix.877766
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+95964@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.bzrignore'
2--- .bzrignore 1970-01-01 00:00:00 +0000
3+++ .bzrignore 2012-03-05 18:12:21 +0000
4@@ -0,0 +1,1 @@
5+.pc
6
7=== modified file 'debian/changelog'
8--- debian/changelog 2012-03-04 19:29:04 +0000
9+++ debian/changelog 2012-03-05 18:12:21 +0000
10@@ -1,3 +1,12 @@
11+lightdm (1.0.6-0ubuntu1.5) oneiric-proposed; urgency=low
12+
13+ * During the login process, make sure to first drop priviledges before
14+ changing to the users home directory. On machines that have user homes
15+ mounted with the option 'root_squash', the root user may not have
16+ permissions and the chdir(1) syscall fails. LP: #877766.
17+
18+ -- Reinhard Tartler <siretart@tauware.de> Fri, 02 Mar 2012 15:04:34 +0100
19+
20 lightdm (1.0.6-0ubuntu1.4) oneiric-security; urgency=low
21
22 * SECURITY UPDATE: file descriptor leak to child processes (LP: #927060)
23
24=== added file 'debian/patches/07_fix_877766.patch'
25--- debian/patches/07_fix_877766.patch 1970-01-01 00:00:00 +0000
26+++ debian/patches/07_fix_877766.patch 2012-03-05 18:12:21 +0000
27@@ -0,0 +1,31 @@
28+=== modified file 'src/session.c'
29+--- a/src/session.c
30++++ b/src/session.c
31+@@ -400,13 +400,6 @@ session_run (Process *process)
32+
33+ user = pam_session_get_user (session->priv->authentication);
34+
35+- /* Change working directory */
36+- if (chdir (user_get_home_directory (user)) != 0)
37+- {
38+- g_warning ("Failed to change to home directory %s: %s", user_get_home_directory (user), strerror (errno));
39+- _exit (EXIT_FAILURE);
40+- }
41+-
42+ /* Change to this user */
43+ if (getuid () == 0)
44+ {
45+@@ -429,6 +422,13 @@ session_run (Process *process)
46+ }
47+ }
48+
49++ /* Change working directory */
50++ if (chdir (user_get_home_directory (user)) != 0)
51++ {
52++ g_warning ("Failed to change to home directory %s: %s", user_get_home_directory (user), strerror (errno));
53++ _exit (EXIT_FAILURE);
54++ }
55++
56+ /* Redirect output to logfile */
57+ if (session->priv->log_file_as_user)
58+ setup_log_file (session);
59
60=== modified file 'debian/patches/series'
61--- debian/patches/series 2012-03-04 19:29:04 +0000
62+++ debian/patches/series 2012-03-05 18:12:21 +0000
63@@ -4,6 +4,7 @@
64 04_CVE-2011-4105.patch
65 05_CVE-2011-3153.patch
66 06_translate_prompt_label.patch
67+07_fix_877766.patch
68 09_show_lang_chooser_option.patch
69 10_available_languages.patch
70 11_set_language_in_accountsservice.patch

Subscribers

People subscribed via source and target branches