Code review comment for lp:~sinzui/launchpad/unactivated-profile-0

On Fri, 2010-06-18 at 18:15 +0000, Brad Crittenden wrote:
> Review: Approve code
> Curtis,
>
> Thanks for the quick turn-around on this bug and for the nice test coverage.
>
> Please s/launchpad/Launchpad in your test narrative.
>
> Also, you demonstrate that an anonymous user cannot see the email
> address but that an admin can. I think it is important to show what a
> regular user sees (or doesn't).

Easily done.

    >>> user_browser.open('https://launchpad.dev/~jvprat')
    >>> print find_tag_by_id(user_browser.contents, 'email-addresses')
    None

Test passed as I expected. If the template permissions are lost, this
will fail.

--
__Curtis C. Hovey_________
http://launchpad.net/