Merge lp:~sinzui/launchpad/reg-docs-1 into lp:launchpad

Proposed by Curtis Hovey
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: 12332
Proposed branch: lp:~sinzui/launchpad/reg-docs-1
Merge into: lp:launchpad
Diff against target: 45 lines (+5/-4)
3 files modified
lib/lp/code/interfaces/ (+2/-1)
lib/lp/code/interfaces/ (+2/-2)
lib/lp/registry/help/openpgp-keys.html (+1/-1)
To merge this branch: bzr merge lp:~sinzui/launchpad/reg-docs-1
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email:

Description of the change

Fix the protocol in the gpg documentation and branch and MP api docs.

    Launchpad bug:
    Pre-implementation: poolie
    Test command: None

Bug #710054 [opengpg keys help gives incorrect protocol in instructions]
    Poolie: We do indeed need to say hkp rather than http in the instructions.

Bug #530476 [branch_merge_proposals doesn't say who created it] seems like it should
    say who proposed the branch
    Poolie: Apparently yes, it's just the docstring is wrong and
    registrant_link is the mp registrant.

Bug #530477 [branch.url is empty?] it looks like the url field is often
    empty? Maybe it's not set for hosted branches; if so maybe the doc could
    mention that.



I already updated the wiki page on

    * Update the inline help to use hkp://keyserver... instead of
    * Update the IBranchMergeProposal registrant description.
    * Update the IBranch url description to mention that the value is None
      for Lp hosted branches.


    * Visit
    * Verify that P"ublishing your key" uses htk://keyserver...
    * Visit
    * Verify that #branch_merge_proposal explains that the registrant
      registred the MP.
    * Verify that #branch explains that the url is None when Lp hosts the




Updated the documentation. There are no tests for these.

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Great collection of fixes Curtis. I do wonder whether we need to specify port 11371. I raise the question and leave it to your unassailable judgment.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/code/interfaces/'
--- lib/lp/code/interfaces/ 2010-11-18 16:13:32 +0000
+++ lib/lp/code/interfaces/ 2011-02-04 18:03:15 +0000
@@ -954,7 +954,8 @@
954 trailing_slash=False,954 trailing_slash=False,
955 description=_(955 description=_(
956 "This is the external location where the Bazaar "956 "This is the external location where the Bazaar "
957 "branch is hosted.")))957 "branch is hosted. This is None when the branch is"
958 "Hosted by Launchpad")))
959 mirror_status_message = exported(960 mirror_status_message = exported(
960 Text(961 Text(
=== modified file 'lib/lp/code/interfaces/'
--- lib/lp/code/interfaces/ 2010-12-02 16:13:51 +0000
+++ lib/lp/code/interfaces/ 2011-02-04 18:03:15 +0000
@@ -107,13 +107,13 @@
108 id = Int(108 id = Int(
109 title=_('DB ID'), required=True, readonly=True,109 title=_('DB ID'), required=True, readonly=True,
110 description=_("The tracking number for this question."))110 description=_("The tracking number for this merge proposal."))
112 registrant = exported(112 registrant = exported(
113 PublicPersonChoice(113 PublicPersonChoice(
114 title=_('Person'), required=True,114 title=_('Person'), required=True,
115 vocabulary='ValidPersonOrTeam', readonly=True,115 vocabulary='ValidPersonOrTeam', readonly=True,
116 description=_('The person who registered the landing target.')))116 description=_('The person who registered the merge proposal.')))
118 source_branch = exported(118 source_branch = exported(
119 ReferenceChoice(119 ReferenceChoice(
=== modified file 'lib/lp/registry/help/openpgp-keys.html'
--- lib/lp/registry/help/openpgp-keys.html 2010-10-28 13:45:04 +0000
+++ lib/lp/registry/help/openpgp-keys.html 2011-02-04 18:03:15 +0000
@@ -69,7 +69,7 @@
69 <p>69 <p>
70 <strong>Step 3</strong> Select <em>Remote &gt; Sync and Publish Keys</em>70 <strong>Step 3</strong> Select <em>Remote &gt; Sync and Publish Keys</em>
71 from the menu. Choose the <em>Sync</em> button. (You may need to add71 from the menu. Choose the <em>Sync</em> button. (You may need to add
72 to your key servers if you are not72 hkp:// to your key servers if you are not
73 using Ubuntu.)73 using Ubuntu.)
74 </p>74 </p>