Code review comment for lp:~sinzui/launchpad/project-packages-portlet-ui

Revision history for this message
Michael Nelson (michael.nelson) wrote :

> On Thu, 2010-04-15 at 10:28 +0000, Michael Nelson wrote:
> > Review: Needs Information ui
> > Thanks Gavin and Paul for including all the info. My initial thought
> > (similar to Gavin) that it seems strange having a single radio
> > (http://people.canonical.com/~curtis/project-without-package-
> suggestions.png), but Curtis, you said:
> >
> > <sinzui> allenap, there will also be an option to say it is not packaged.
>
> This UI branch came from the branch that allows users to say "This is
> not packaged in Ubuntu". There will always be two radio items. The
> additional option will land Friday or Monday. The not-packaged branch
> was blocked over the model implementation, so I decided to extract the
> UI and apply the UI suggestions from abently, james_w, Edwin, and bac,

Great, that's all I needed to know :)

> The "Ubuntu Hoary packages" label was added from Edwin's UI review of
> the not-packages branch. He was correct in pointing out that the
> packages and the operation is about the current development series.

Yep, I think the label is great when there is a selection to make.

Thanks!

review: Approve (ui)

« Back to merge proposal