Code review comment for lp:~sinzui/launchpad/progressive-enhancement-ftw

Revision history for this message
Curtis Hovey (sinzui) wrote :

We, well myself and former members of the registry team, tried to solve the div span issue. It is tricky work. The root issues is that HTML and Lp require all widgets to work as inline elements because they can be placed in markup that only permits inline elements, such as a paragraph. This work is out of scope for this branch. I believe we have a better chance of fixing this issue now that Lp intends to be HTML5. I think we want to switch everything to span and use inline-blocks when needed.

I agree that we want titles on the links.

Yes, we have code that declares that it uses a module that is in an egg.

The container element is needed so that lp.app.expander can find the second chunk and add the lazr-closed class.

« Back to merge proposal