Approved* (Brad will have to review my review since I'm doing mentored
reviews.)
The test (like the rest of the branch) is nice and clean. I almost
suggested using list(walker) instead of the (apparently) do-nothing
loop, but I'm not sure if using list() is just clearer to me and most
people would understand the intent of the current code better.
I especially like the fact that the WalkerBase import can be moved to
the top of the test module. Much nicer now.
Approved* (Brad will have to review my review since I'm doing mentored
reviews.)
The test (like the rest of the branch) is nice and clean. I almost
suggested using list(walker) instead of the (apparently) do-nothing
loop, but I'm not sure if using list() is just clearer to me and most
people would understand the intent of the current code better.
I especially like the fact that the WalkerBase import can be moved to
the top of the test module. Much nicer now.