def test_admins_are_teams_with_preferred_email_addresses(self):
106 + # The team's admin is a team without a contact address.
107 + # The admin team members provide the email addresses.
108 + admin_team = self.setUpAdminingTeam(self.team)
109 + admin_team.setContactAddress(
110 + self.factory.makeEmail('<email address hidden>', admin_team))
111 + self.assertEqual(
112 + ['<email address hidden>'], self.team.getTeamAdminsEmailAddresses())
113 +
114 + def test_admins_are_teams_without_preferred_email_addresses(self):
looks like you have them inverted: that is that the name and comment of the former test describes the behaviour of the latter test, and vice versa.
def test_admins_ are_teams_ with_preferred_ email_addresses (self): ingTeam( self.team) setContactAddre ss( makeEmail( '<email address hidden>', admin_team)) getTeamAdminsEm ailAddresses( )) are_teams_ without_ preferred_ email_addresses (self):
106 + # The team's admin is a team without a contact address.
107 + # The admin team members provide the email addresses.
108 + admin_team = self.setUpAdmin
109 + admin_team.
110 + self.factory.
111 + self.assertEqual(
112 + ['<email address hidden>'], self.team.
113 +
114 + def test_admins_
looks like you have them inverted: that is that the name and comment of the former test describes the behaviour of the latter test, and vice versa.
Other than that this looks good.