Code review comment for lp:~sinzui/launchpad/override-blacklist-0
Revision history for this message
| Stuart Bishop (stub) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
The guard for user_id shouldn't be needed; "WHERE person = 0" will give the same results as "WHERE person = NULL" (the former evaluates to FALSE for every row, the latter to NULL for every row, but both filter all rows in this context). It makes no practical difference so whatever you feel is clearer.
By removing privileges from a group of admins (registry or admin or both), will we end up with cases where something private cannot be created because there is no overlap between the set of people who can can create the object with a blacklisted name and the set of people who can create private objects?