Code review comment for lp:~sinzui/launchpad/override-blacklist-0

Hi Sinzui,

the code changes looks good to me.

But I share Stuart's concern that persons registered as a nameblacklist.admin do not get the slightest hint that a new project name is blackisted. My concern i not that much about the LOSAs If they are asked to set a project name to a blacklisted value, we can be sure that the request explains the reason why the blacklist should be overridden. And the LOSAs did prove that they work very carefully, so I am confident that they check if the request makes sense. (But they might appreciate display of the affected blackist record's regex value and comment so they can easily see why a given name is blacklisted.)

But if we use the option to appoint arbitrary persons as nameblacklist.admin, things might become messy. Let's assume that somebody is the admin for two nameblacklist records, where the two records blacklist names related to two different project groups. If this person now creates a new product for group A, but the name is blacklisted to prevent "stealing" names reserved for group B, they do not get the slightest hint that they are making an error. (I would probably be the first one to walk into this trap ;)