Code review comment for lp:~sinzui/launchpad/merge-mailing-list-bug-471770

Revision history for this message
Abel Deuring (adeuring) wrote :

Hi Curtis,

nice branch. I have only two spelling questions/suggestions.

Abel

> === added file 'lib/canonical/launchpad/emailtemplates/person-merged.txt'
> --- lib/canonical/launchpad/emailtemplates/person-merged.txt 1970-01-01 00:00:00 +0000
> +++ lib/canonical/launchpad/emailtemplates/person-merged.txt 2009-11-12 21:15:25 +0000
> @@ -0,0 +1,15 @@
> +
> +The Launchpad account named '%(dupename)s' was merged into the account
> +named '%(person)s'. You can confirm the merged email addresses to
> +associate them with your account. Merged email address are unsubscribed

I think that should be "email addresses are".

> +from all Launchpad mailing lists during the merge. All team memberships
> +for the merged account were also transfered to your account, and

I am not sure, but shouldn't this be "transferred"?

> +those team may have mailing lists.
> +
> +You can review and update your email and subscription settings at:
> +
> + https://launchpad.net/~%(person)s/+editemails
> +
> +Thank you,
> +
> +The Launchpad team

review: Approve (code)

« Back to merge proposal