Merge lp:~sinzui/launchpad/mailing-list-subscribers-cache-0 into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11444 |
Proposed branch: | lp:~sinzui/launchpad/mailing-list-subscribers-cache-0 |
Merge into: | lp:launchpad |
Diff against target: |
25 lines (+2/-2) 2 files modified
lib/lp/registry/templates/person-participation.pt (+1/-1) lib/lp/registry/templates/team-mailinglist-subscribers.pt (+1/-1) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/mailing-list-subscribers-cache-0 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+33681@code.launchpad.net |
Description of the change
This is my branch to adjust the cache rules showing mailing list
subscriptions.
lp:~sinzui/launchpad/mailing-list-subscribers-cache-0
Diff size: 26
Launchpad bug:
https:/
Test command: ./bin/test -vv \
-t test_person_view -t xx-team-membership
-t mailinglists/
Pre-
Target release: 10.09
Adjust the cache rules showing mailing list subscriptions
-------
<beuno>
I had the following problem:
- Someone signs up for a mailing list
- I look at the current subscribers and that person isn't listed, however,
they can see that they *are* subscribed
- Disabling the edge redirect and going to production shows the updated data
I waited for at least 10 minutes for this to be updated.
<sinzui>
We just completed our query optimisations for this page so we can consider
changing the cache rules. I propose caching for 10 minutes for anonymous users
only. Logged in users are working so they expect to see changes.
We should also update +participation since its queries were also updated. We
should use anonymous as well because logged in users are currently getting a
private cache, which is not very helpful.
Rules
-----
* Update +subscribers to cache anonymous only.
* Update +participation to cache anonymous only.
QA
--
* Visit your +participation page as an anonymous user.
* Follow a link to a team that you are subscribed too.
* View the list of subscribers and find yourself.
* Visit your +participation page as yourself.
* Follow a link to a team that you are subscribed too.
* View the list of subscribers and find yourself.
* Return to your profile page and choose edit emails.
* Unsubscribe from the list under test.
* Visit your +participation page as yourself.
* Verify you are not listed as subscribed.
* Visit the team and look at the subscribers page
* Verify you are not listed.
* Visit your +participation page as an anonymous user.
* Verify you are still listed as subscribed
* Follow a link to a team that you are subscribed too.
* View the list of subscribers and find yourself.
* Wait 10 minutes.
* Visit your +participation page as an anonymous user.
* Verify you are not listed as subscribed.
* Follow a link to a team that you are subscribed too.
* View the list of subscribers verify you are not in the list.
Lint
----
Linting changed files:
lib/lp/
lib/lp/
Test
----
No tests changed. The existing tests verify that cache rules are present,
but they do not concern themselves with the exact condition.
Implementation
--------------
Changed the cache to anonymous, 10 minutes in:
* lib/lp/
* lib/lp/