Code review comment for lp:~sinzui/launchpad/lost-glob-bug-484365

On Thu, 2009-11-19 at 15:46 +0000, Michael Nelson wrote:
> Review: Approve code
> Wow - you always do such clean branches Curtis - it's great to review!
>
> The only comment I could make is actually in the form of Barry's voice
> in my head - whether you want to take the time to add the doc params
> to IProductDriverRestricted.newSeries().

I agree.

--- lib/lp/registry/interfaces/product.py 2009-11-19 04:39:48 +0000
+++ lib/lp/registry/interfaces/product.py 2009-11-19 16:18:54 +0000
@@ -273,7 +273,17 @@
     """`IProduct` properties which require launchpad.Driver permission."""

     def newSeries(owner, name, summary, branch=None, releasefileglob=None):
- """Creates a new ProductSeries for this product."""
+ """Creates a new `IProductSeries` for this `IProduct`.
+
+ :param owner: The registrant of this series.
+ :param name: The unique name of this series.
+ :param summary: The summary of the purpose and focus of development
+ of this series.
+ :param branch: The bazaar branch that contains the code for
+ this series.
+ :param releasefileglob: The public URL pattern where release files can
+ be automatically downloaded from and linked to this series.
+ """

 class IProductEditRestricted(IOfficialBugTagTargetRestricted,):

--
__Curtis C. Hovey_________
http://launchpad.net/