Launchpad itself

Code review comment for lp:~sinzui/launchpad/css-ui-0

  1. css-ui-0
  2. Merge into devel
Revision history for this message
Curtis Hovey (sinzui) wrote :

On Thu, 2010-12-16 at 22:15 +0000, Edwin Grubbs wrote:
> Review: Approve code
> Hi Curtis,
>
> This branch looks good. I just have some minor comments.
>
> -Edwin
>
> >=== modified file 'lib/canonical/launchpad/offline-maintenance-haproxy.html'
> >--- lib/canonical/launchpad/offline-maintenance-haproxy.html 2010-04-01 13:43:01 +0000
> >+++ lib/canonical/launchpad/offline-maintenance-haproxy.html 2010-12-16 18:25:39 +0000
> >@@ -6,7 +6,17 @@
> > <head>
> > <title>Launchpad is offline for maintenance</title>
> > <style type="text/css" media="screen, print">
> >- .offline{text-align:center;margin:2em 0}
> >+ html, body {
> >+ font-family: UbuntuBeta, Ubuntu, 'Bitstream Vera Sans', 'DejaVu Sans', Tahoma, sans-serif;
> >+ }
> >+ .offline {
> >+ text-align: center;
> >+ max-width: 60em;
> >+ }
> >+ .offline > * {
> >+ margin-left: auto;
> >+ margin-right: auto;
> >+ }
> > </style>
> > </head>
> > <body>
>
>
> This file has CR/LF. How did that happen?

I think they have always been like that. Both haproxy page may have been
cargo culted from somewhere else.

--
__Curtis C. Hovey_________
http://launchpad.net/

« Back to merge proposal