Code review comment for lp:~sinzui/launchpad/css-rip-0

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Wow, that's an excellent improvement... it's definitely much easier to understand the categories. Hopefully any fallout that we see on Edge from this change will only lead to further improvements in the style-sheet.

{{{
16:29 < sinzui> noodles775, I have an awesome (and I mean that in the historical context) branch that updates CSS. I hope you can find time to review it
16:29 < noodles775> sinzui: great!
16:47 < noodles775> sinzui: In your MP text, you mention removing the duplicate css for ul/li.language, but afaics MP diff just shows those as moved?
16:48 < noodles775> Wow... the re-org. looks excellent.
16:48 < sinzui> noodles775, it was defined twice!
16:50 < noodles775> sinzui: but on your MP, I can see it added (from a move) on lines 340ff, removed on lines 1578ff, ah, right, then removed again at 3228. OK.
16:52 < sinzui> noodles775, I really hope that future additions/changes to the css will be easier with this reorganisation. I lost my evening to an obsessive need to understand all the rules we are using
16:52 < noodles775> sinzui: I think it definitely will... and yes, looking at the organisation I can see why it took an evening!
}}}

review: Approve (code)

« Back to merge proposal