Merge lp:~sinzui/launchpad/commercial-jobsource-zcml into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Curtis Hovey |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15422 |
Proposed branch: | lp:~sinzui/launchpad/commercial-jobsource-zcml |
Merge into: | lp:launchpad |
Diff against target: |
219 lines (+95/-8) 7 files modified
cronscripts/daily_product_jobs.py (+1/-1) database/schema/security.cfg (+6/-0) lib/lp/registry/configure.zcml (+31/-0) lib/lp/registry/model/productjob.py (+3/-0) lib/lp/registry/tests/test_productjob.py (+52/-3) lib/lp/services/config/schema-lazr.conf (+2/-2) logs/README.txt (+0/-2) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/commercial-jobsource-zcml |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+110365@code.launchpad.net |
Commit message
Register the commercial email job sources and add db permissions.
Description of the change
process-
are not registered in ZCML. Clearly, a test is missing that demonstrates
the ZCML, schema-lazr.conf, and security.cfg are configured properly.
I really botched this. I new what test was missing when I discovered the
bug. There are two cronscripts used in this process, and I only wrote
tests for the script I wrote. I need to also write a test for the script
I reused.
-------
RULES
Pre-
* Add the missing ZCML needed to register the secured utilities.
* Add tests to verify the three kinds of job are run.
* Fix any db permissions that are proven to fail.
* Fix the ICommercialExpi
in the schema.
QA
On qastaging, as a webops to run
* cronscripts/
* cronscripts/
* cronscripts/
LINT
cronscripts
database/
lib/
lib/
lib/
lib/
TEST
./bin/test -vvc lp.registry.
IMPLEMENTATION
Fixed the class name used to lookup jobs
ICommercialExpi
cronscripts
lib/
Added a test to the test mixin to verify that the three kinds of
commercial notification job can be run by process-
discovered that there is two run_script() test helpers with different
IO. I chose to use update an existing test to use the one from
lp.testing because it allows me to pass the environ to get better test
output.
lib/
lib/
Added the missing ZCML registration that permits process-
to lookup the job source class and then have permission to use the job
instance.
lib/
Fixed the db permissions demonstrated to be need by the new test. The
packaging/distro tables are needed because there is a sanity check in
the product deactivation code that ensure Ubuntu does not loose an
upstream packaging link
database/
Curtis--
This looks fine; I'm a little confused about the block of lp.services imports being moved--is there some sort of interference if they're sorted normally?