Code review comment for lp:~sinzui/launchpad/bug-tag-completions

Revision history for this message
j.c.sackett (jcsackett) wrote :

Curtis--

This looks good. Just one style note.

In a few places (line 226 or 311, for example): It looks like you're doing
pythonic brace/paren closure in places. I think for javascript we have the
closing brace at the same tab level as the opening call, rather than at the
tab level of the enclosed lines.

In other words, I believe we prefer:

  some_call(function () {
    stuff;
  });

Rather than:

  some_call(function () {
    stuff;
    });

review: Approve

« Back to merge proposal