Code review comment for lp:~sinzui/launchpad/apply-commercial-subscription

Revision history for this message
Brad Crittenden (bac) wrote :

Hi Curtis,

Thanks for all of the fixes here.

At 204 and 225 the failure message should reference self.num_commercial. You can probably just delete the custom message as the default is pretty descriptive.

236: typo: deactivated. In that comment I'd s/fails/returns no results/

345: s/projects user maintains, or all active project/
       project the user maintains, or all active projects/

Otherwise this looks like a great improvement, both in terms of adding the functionality needed and cleanliness.

review: Approve (code)

« Back to merge proposal