Code review comment for lp:~sinzui/launchpad/answers-ui-fixes

This is my branch to fix faq and question 3.0 bugs.

    lp:~sinzui/launchpad/faqs-ui-fixes
    Diff size: 562
    Launchpad bug: https://bugs.launchpad.net/bugs/435743
                   https://bugs.launchpad.net/bugs/435973
                   https://bugs.launchpad.net/bugs/434715
    Test command: /bin/test -vvc -t answers.*(browser|stories)
    Pre-implementation: no one
    Target release: 3.1.11

= Convert faq layouts to 3.0 =

Bug 435743 [Bread crumb missing for question and FAQ]
    The last segment of the breadcrumb is missing.

Bug 435973 [FAQ page headings are too verbose]
    The heading should be the FAQ title, but it contains the project and
    id that is expected to appear in the breadcrumbs

Bug 434715 [Button for asking a question is labeled "Add"]
    Change the action from Add to Post Question,

== Rules ==

Bug 435743 [Bread crumb missing for question and FAQ]
    * The FAQ is missing a Breadcrumb adapter; add one:
      FAQ #1234

Bug 435973 [FAQ page headings are too verbose]
    * The heading should be the FAQ title, no more.

Bug 434715 [Button for asking a question is labeled "Add"]
    Change the action from Add to Post Question.

== QA ==

Bug 435743 [Bread crumb missing for question and FAQ]
    Visit an FAQ and verify the breadcrumbs are:
    <project> : questions : faqs : FAQ #<id>

Bug 435973 [FAQ page headings are too verbose]
    Visit an FAQ and verify that the FAQ title is the entire heading

Bug 434715 [Button for asking a question is labeled "Add"]
    Verify the action to create a question is Post Question,

== Lint ==

Linting changed files:
  lib/lp/answers/browser/configure.zcml
  lib/lp/answers/browser/faq.py
  lib/lp/answers/browser/question.py
  lib/lp/answers/browser/tests/test_breadcrumbs.py
  lib/lp/answers/stories/faq-add.txt
  lib/lp/answers/stories/faq-browse-and-search.txt
  lib/lp/answers/stories/faq-edit.txt
  lib/lp/answers/stories/project-add-question.txt
  lib/lp/answers/stories/question-add-in-other-languages.txt
  lib/lp/answers/stories/question-add.txt
  lib/lp/answers/stories/question-answer-contact.txt
  lib/lp/answers/stories/question-browse-and-search.txt
  lib/lp/answers/stories/question-message.txt
  lib/lp/answers/stories/question-obfuscation.txt
  lib/lp/answers/stories/question-overview.txt
  lib/lp/answers/stories/this-is-a-faq.txt

== Test ==

    * lib/lp/answers/browser/tests/test_breadcrumbs.py
      * Added tests for FAQ and Question Breadcrumbs
    * lib/lp/answers/stories/faq-add.txt
      * Updated tests to verify FAQ titles.
    * lib/lp/answers/stories/faq-browse-and-search.txt
      * Updated tests to verify FAQ titles.
    * lib/lp/answers/stories/faq-edit.txt
      * Updated tests to verify FAQ titles.
    * lib/lp/answers/stories/project-add-question.txt
      * Updated tests to verify the create action is Post Question.
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/question-add-in-other-languages.txt
      * Updated tests to verify the create action is Post Question.
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/question-add.txt
      * Updated tests to verify the create action is Post Question.
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/question-answer-contact.txt
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/question-browse-and-search.txt
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/question-message.txt
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/question-obfuscation.txt
      * Updated tests to verify the create action is Post Question.
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/question-overview.txt
      * Updated tests to verify Question titles.
    * lib/lp/answers/stories/this-is-a-faq.txt
      * Updated tests to verify Question titles.

== Implementation ==

    * lib/lp/answers/browser/configure.zcml
      * Registered IBreadcrumb adapters for IFAQ and IQuestion.
    * lib/lp/answers/browser/faq.py
      * Added a Breadcrumb adapter for FAQ.
      * Removed the redundant title.
      * Simplified the label (page heading).
    * lib/lp/answers/browser/question.py
      * Added a Breadcrumb adapter for Question.
      * Removed old Zope hack, project-add-question.txt works fine with the
        method name, the callable is not needed.
      * Changed the Add action to Post Question.