Merge lp:~sinzui/juju-release-tools/win10-agents into lp:juju-release-tools

Proposed by Curtis Hovey
Status: Merged
Merged at revision: 263
Proposed branch: lp:~sinzui/juju-release-tools/win10-agents
Merge into: lp:juju-release-tools
Diff against target: 53 lines (+7/-4)
3 files modified
agent_archive.py (+3/-0)
make_agent_json.py (+2/-2)
tests/test_agent_archive.py (+2/-2)
To merge this branch: bzr merge lp:~sinzui/juju-release-tools/win10-agents
Reviewer Review Type Date Requested Status
Aaron Bentley (community) Approve
Review via email: mp+286347@code.launchpad.net

Description of the change

Add win10, win2016, and win2016nano agents.

This branch adds win10, win2016, and win2016nano to the list of agents we make.
These additions match known version in
    https://github.com/juju/utils/blob/master/series/supportedseries.go

It is okay to create agents for versions that older jujus don't know. We just want to be certain there are agents for series we expect juju to provision.

To post a comment you must log in.
Revision history for this message
Aaron Bentley (abentley) wrote :

Thank you.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'agent_archive.py'
--- agent_archive.py 2015-08-06 21:31:53 +0000
+++ agent_archive.py 2016-02-17 15:50:52 +0000
@@ -20,9 +20,12 @@
20 'juju-{}-win2012hv-amd64.tgz',20 'juju-{}-win2012hv-amd64.tgz',
21 'juju-{}-win2012r2-amd64.tgz',21 'juju-{}-win2012r2-amd64.tgz',
22 'juju-{}-win2012-amd64.tgz',22 'juju-{}-win2012-amd64.tgz',
23 'juju-{}-win2016-amd64.tgz',
24 'juju-{}-win2016nano-amd64.tgz',
23 'juju-{}-win7-amd64.tgz',25 'juju-{}-win7-amd64.tgz',
24 'juju-{}-win8-amd64.tgz',26 'juju-{}-win8-amd64.tgz',
25 'juju-{}-win81-amd64.tgz',27 'juju-{}-win81-amd64.tgz',
28 'juju-{}-win10-amd64.tgz',
26)29)
27# The versions of agent that may or will exist. The agents will30# The versions of agent that may or will exist. The agents will
28# always start with juju, the series will start with "win" and the31# always start with juju, the series will start with "win" and the
2932
=== modified file 'make_agent_json.py'
--- make_agent_json.py 2016-02-09 19:55:34 +0000
+++ make_agent_json.py 2016-02-17 15:50:52 +0000
@@ -12,8 +12,8 @@
1212
1313
14supported_windows_releases = (14supported_windows_releases = (
15 'win2012', 'win2012hv', 'win2012hvr2', 'win2012r2', 'win7', 'win81',15 'win2012', 'win2012hv', 'win2012hvr2', 'win2012r2', 'win2016',
16 'win8',16 'win2016nano', 'win7', 'win81', 'win8', 'win10',
17 )17 )
1818
1919
2020
=== modified file 'tests/test_agent_archive.py'
--- tests/test_agent_archive.py 2015-08-06 21:30:00 +0000
+++ tests/test_agent_archive.py 2016-02-17 15:50:52 +0000
@@ -190,7 +190,7 @@
190 nv_mock.assert_called_with(190 nv_mock.assert_called_with(
191 os.path.abspath('juju-1.21.0-win2012-amd64.tgz'),191 os.path.abspath('juju-1.21.0-win2012-amd64.tgz'),
192 None, verbose=False)192 None, verbose=False)
193 self.assertEqual(7, mock.call_count)193 self.assertEqual(10, mock.call_count)
194 output, args, kwargs = mock.mock_calls[0]194 output, args, kwargs = mock.mock_calls[0]
195 agent_path = os.path.abspath(cmd_args.source_agent)195 agent_path = os.path.abspath(cmd_args.source_agent)
196 self.assertEqual(196 self.assertEqual(
@@ -205,7 +205,7 @@
205 's3://juju-qa-data/agent-archive/'205 's3://juju-qa-data/agent-archive/'
206 'juju-1.21.0-win2012hvr2-amd64.tgz'],206 'juju-1.21.0-win2012hvr2-amd64.tgz'],
207 args[0])207 args[0])
208 output, args, kwargs = mock.mock_calls[6]208 output, args, kwargs = mock.mock_calls[8]
209 self.assertEqual(209 self.assertEqual(
210 ['cp',210 ['cp',
211 's3://juju-qa-data/agent-archive/juju-1.21.0-win2012-amd64.tgz',211 's3://juju-qa-data/agent-archive/juju-1.21.0-win2012-amd64.tgz',

Subscribers

People subscribed via source and target branches