Code review comment for lp:~sinzui/juju-ci-tools/wait-for-upgrade

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

This looks good, but I'd prefer we put a small comment in as to why we are doing the additional wait. A summary of what you've said above for future reference in the test. Namely, upgrades occur on agent and potentially db as well. Juju doesn't tell us when it's truly done. We are using list-models as the proxy for 'juju done'.

review: Approve

« Back to merge proposal