Code review comment for lp:~sinzui/bzr-gtk/gtk3

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/07/2011 06:40 PM, Curtis Hovey wrote:
> Curtis Hovey has proposed merging lp:~sinzui/bzr-gtk/gtk3 into lp:bzr-gtk.
>
> Requested reviews:
> Bazaar GTK maintainers (bzr-gtk)
>
> For more details, see:
> https://code.launchpad.net/~sinzui/bzr-gtk/gtk3/+merge/74472
>
> Update bzr-gtk to Gtk3.
>
> Launchpad bug: https://bugs.launchpad.net/bugs/796856
> Pre-implementation: no one
>
> bzr-gtk commands, widgets, cannot be used in a process that has imported gtk3.
> Gtk-ERROR **: GTK+ 2.x symbols detected. Using GTK+ 2.x and GTK+ 3 in the
> same process is not supported Trace/breakpoint trap
>
> The general approach to fix this is to
> create a gtk3 series
> Run pygi.convert.sh found in pygi's tree
> Update all the obsolete 2.x calls to 3.
>
> The majority of this branch is mechanical changes as outlined in the rules
> below. There are three changes that should be given more attention in the
> review:

I don't think bzr-gtk is particularly well supported by "upstream" at
this point. So I'm going to rubber stamp your work, assuming you did a
good job. We can wait a bit, and see if anyone complains before landing
it. But the patch is large enough, I don't think people will really go
through it anyway.

 review: approve

> This branch works very well for my self, but I am sure that there are gtk3
> conversion issues that I have not discovered. I more users are now needed
> to find bugs.

I think that is a pretty good estimate, though.

I think overall this is an improvement, which may not be perfect, but it
better than the status quo, so it should be merged.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5ofE0ACgkQJdeBCYSNAAMYRwCcDPSACyo8oYL6NLJXXyx6L4Xj
X1YAoNM+3TvYygZwFZr1mL1ZhufTNCOv
=sgU+
-----END PGP SIGNATURE-----