Code review comment for lp:~sinzui/bzr-gtk/gtk3

Hi Curtis,

Thanks again for working on this, much appreciated. :)

Feel free to already push to lp:bzr-gtk/gtk3, which was a branch created earlier for gtk3 porting. I think we should create a lp:bzr-gtk/gtk2 once we merge your work into trunk, for people who are still using older versions of GNOME/GTK.

Trying out your branch on Oneiric I'm getting the following error on the terminal, and no visual graph in the "viz" window:
TypeError: Couldn't find conversion for foreign struct 'cairo.Context'

This seems like a Cairo bug to me - do I need a newer version or something?

Switching to a wide layout crashes here:
Traceback (most recent call last):
  File "/home/jelmer/src/bzr-gtk/gtk3/viz/branchwin.py", line 571, in _vertical_layout
    self.construct_paned(), True, True, True, 0)
  File "/usr/lib/python2.7/dist-packages/gi/types.py", line 43, in function
    return info.invoke(*args, **kwargs)
TypeError: pack_start() takes exactly 5 arguments (6 given)

gloom crashes with another traceback:
  File "/home/jelmer/src/bzr-gtk/gtk3/commands.py", line 117, in run
    dialog = LoomDialog(br, tree)
  File "/home/jelmer/src/bzr-gtk/gtk3/loom.py", line 42, in __init__
    self._construct()
  File "/home/jelmer/src/bzr-gtk/gtk3/loom.py", line 80, in _construct
    hbox.pack_end(self._diff)
  File "/usr/lib/python2.7/dist-packages/gi/types.py", line 43, in function
    return info.invoke(*args, **kwargs)
TypeError: pack_end() takes exactly 5 arguments (2 given)