Ubuntu
landscape-client package

Code review comment for ~simpoir/ubuntu/+source/landscape-client:disco-mem-usage-1685885

  1. Git
  2. lp:~simpoir/ubuntu/+source/landscape-client
  3. disco-mem-usage-1685885
  4. Merge into ubuntu/disco-devel
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks, this looks good and is a +1.

Two points, for the next ones:
- please separate the d/changelog change into its own commit. It helps tremendously when backporting (cherry-picking) fixes for SRUs (which you might have discovered, since this fix will be SRUed), and also when just wanting to take a peek at what the actual changes are, without d/changelog "noise" :)
- make the MP for the development release of ubuntu against the ubuntu/devel branch, that is always the development release. Today it matches ubuntu/disco-devel.

review: Approve

« Back to merge proposal