Merge lp:~simpoir/landscape-bundles/bumpitty-bump into lp:landscape-bundles

Proposed by Simon Poirier
Status: Merged
Approved by: Simon Poirier
Approved revision: 55
Merged at revision: 55
Proposed branch: lp:~simpoir/landscape-bundles/bumpitty-bump
Merge into: lp:landscape-bundles
Diff against target: 51 lines (+5/-5)
2 files modified
landscape-template.jinja2 (+3/-3)
update-charm-revisions (+2/-2)
To merge this branch: bzr merge lp:~simpoir/landscape-bundles/bumpitty-bump
Reviewer Review Type Date Requested Status
Maximiliano Bertacchini Approve
Review via email: mp+406125@code.launchpad.net

Commit message

Fix update-charm-revisions regexp to match current charm Id scheme and bump charms revision.

Description of the change

update-charm-revisions regexp to match current charm Id scheme.

Also bump charms.
This should include this rabbitmq-server HA race condition fix
(https://opendev.org/openstack/charm-rabbitmq-server/commit/dcb3058ff2b730f573329c32a85381a05bd743d3)

thus removing the HA oddities of this related MP
https://code.launchpad.net/~simpoir/landscape-charm/1501803_ha_amqp/+merge/406052

To post a comment you must log in.
Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'landscape-template.jinja2'
--- landscape-template.jinja2 2019-04-05 10:20:26 +0000
+++ landscape-template.jinja2 2021-07-22 23:23:12 +0000
@@ -1,7 +1,7 @@
1series: bionic1series: bionic
2services:2services:
3 rabbitmq-server:3 rabbitmq-server:
4 charm: cs:rabbitmq-server-854 charm: cs:rabbitmq-server-111
5 {% if rabbitmq["to"] %}5 {% if rabbitmq["to"] %}
6 to:6 to:
7 - {{ rabbitmq["to"] }}7 - {{ rabbitmq["to"] }}
@@ -11,7 +11,7 @@
11 "gui-x": "600"11 "gui-x": "600"
12 "gui-y": "370"12 "gui-y": "370"
13 postgresql:13 postgresql:
14 charm: cs:postgresql-19914 charm: cs:postgresql-234
15 {% if postgresql["memory"] %}15 {% if postgresql["memory"] %}
16 constraints: mem={{ postgresql["memory"] }}16 constraints: mem={{ postgresql["memory"] }}
17 {% endif %}17 {% endif %}
@@ -46,7 +46,7 @@
46 "gui-x": "600"46 "gui-x": "600"
47 "gui-y": "120"47 "gui-y": "120"
48 haproxy:48 haproxy:
49 charm: cs:haproxy-4849 charm: cs:haproxy-61
50 {% if haproxy["to"] %}50 {% if haproxy["to"] %}
51 to:51 to:
52 - "{{ haproxy["to"] }}"52 - "{{ haproxy["to"] }}"
5353
=== modified file 'update-charm-revisions'
--- update-charm-revisions 2019-04-05 12:51:18 +0000
+++ update-charm-revisions 2021-07-22 23:23:12 +0000
@@ -51,7 +51,7 @@
51 be tested and checked in if successful.51 be tested and checked in if successful.
5252
53 Look for lines like:53 Look for lines like:
54 charm: cs:trusty/juju-gui-8354 charm: cs:juju-gui-83
5555
56 Or:56 Or:
57 series: trusty57 series: trusty
@@ -60,7 +60,7 @@
60 pattern = "^(\s*)series:\s.*$"60 pattern = "^(\s*)series:\s.*$"
61 line = re.sub(pattern, r"\1series: %s" % series, line)61 line = re.sub(pattern, r"\1series: %s" % series, line)
62 for charm in charms:62 for charm in charms:
63 pattern = "cs:[^/]+/{}-[0-9]+".format(charm.name)63 pattern = "cs:{}-[0-9]+".format(charm.name)
64 line = re.sub(pattern, charm.store_url, line)64 line = re.sub(pattern, charm.store_url, line)
65 sys.stdout.write(line)65 sys.stdout.write(line)
6666

Subscribers

People subscribed via source and target branches

to all changes: