Merge lp:~simone.busoli/nunitv2/nunitv2 into lp:nunitv2

Proposed by Simone Busoli
Status: Merged
Approved by: Charlie Poole
Approved revision: 3439
Merged at revision: 3439
Proposed branch: lp:~simone.busoli/nunitv2/nunitv2
Merge into: lp:nunitv2
Diff against target: 54 lines (+20/-4)
2 files modified
src/ConsoleRunner/nunit-console/ConsoleOptions.cs (+7/-1)
src/ConsoleRunner/nunit-console/ConsoleUi.cs (+13/-3)
To merge this branch: bzr merge lp:~simone.busoli/nunitv2/nunitv2
Reviewer Review Type Date Requested Status
Charlie Poole Approve
Review via email: mp+129792@code.launchpad.net

Description of the change

Basically used the patches provided by the user for the two additional console options, with minor modifications

To post a comment you must log in.
Revision history for this message
Charlie Poole (charlie.poole) wrote :

Looks good. No tests, but I added them.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/ConsoleRunner/nunit-console/ConsoleOptions.cs'
--- src/ConsoleRunner/nunit-console/ConsoleOptions.cs 2012-07-09 18:33:10 +0000
+++ src/ConsoleRunner/nunit-console/ConsoleOptions.cs 2012-10-16 01:51:17 +0000
@@ -73,7 +73,13 @@
73 public bool noshadow;73 public bool noshadow;
7474
75 [Option (Description = "Disable use of a separate thread for tests")]75 [Option (Description = "Disable use of a separate thread for tests")]
76 public bool nothread;76 public bool nothread;
77
78 [Option(Description = "Base path to be used when loading the assemblies")]
79 public string basepath;
80
81 [Option(Description = "Additional directories to be probed when loading assemblies, separated by semicolons")]
82 public string privatebinpath;
7783
78 [Option(Description = "Set timeout for each test case in milliseconds")]84 [Option(Description = "Set timeout for each test case in milliseconds")]
79 public int timeout;85 public int timeout;
8086
=== modified file 'src/ConsoleRunner/nunit-console/ConsoleUi.cs'
--- src/ConsoleRunner/nunit-console/ConsoleUi.cs 2012-10-14 22:44:01 +0000
+++ src/ConsoleRunner/nunit-console/ConsoleUi.cs 2012-10-16 01:51:17 +0000
@@ -311,6 +311,17 @@
311 domainUsage = DomainUsage.Multiple;311 domainUsage = DomainUsage.Multiple;
312 }312 }
313313
314 if (options.basepath != null && options.basepath != string.Empty)
315 {
316 package.BasePath = options.basepath;
317 }
318
319 if (options.privatebinpath != null && options.privatebinpath != string.Empty)
320 {
321 package.AutoBinPath = false;
322 package.PrivateBinPath = options.privatebinpath;
323 }
324
314#if CLR_2_0 || CLR_4_0325#if CLR_2_0 || CLR_4_0
315 if (options.framework != null)326 if (options.framework != null)
316 framework = RuntimeFramework.Parse(options.framework);327 framework = RuntimeFramework.Parse(options.framework);
@@ -326,11 +337,10 @@
326 337
327 package.Settings["ProcessModel"] = processModel;338 package.Settings["ProcessModel"] = processModel;
328 package.Settings["DomainUsage"] = domainUsage;339 package.Settings["DomainUsage"] = domainUsage;
329 if (framework != null)340
341 if (framework != null)
330 package.Settings["RuntimeFramework"] = framework;342 package.Settings["RuntimeFramework"] = framework;
331343
332
333
334 if (domainUsage == DomainUsage.None)344 if (domainUsage == DomainUsage.None)
335 {345 {
336 // Make sure that addins are available346 // Make sure that addins are available

Subscribers

People subscribed via source and target branches

to status/vote changes: