Merge lp:~simone.busoli/nunitv2/nunitv2 into lp:nunitv2

Proposed by Simone Busoli
Status: Merged
Approved by: Charlie Poole
Approved revision: 3439
Merged at revision: 3439
Proposed branch: lp:~simone.busoli/nunitv2/nunitv2
Merge into: lp:nunitv2
Diff against target: 54 lines (+20/-4)
2 files modified
src/ConsoleRunner/nunit-console/ConsoleOptions.cs (+7/-1)
src/ConsoleRunner/nunit-console/ConsoleUi.cs (+13/-3)
To merge this branch: bzr merge lp:~simone.busoli/nunitv2/nunitv2
Reviewer Review Type Date Requested Status
Charlie Poole Approve
Review via email: mp+129792@code.launchpad.net

Description of the change

Basically used the patches provided by the user for the two additional console options, with minor modifications

To post a comment you must log in.
Revision history for this message
Charlie Poole (charlie.poole) wrote :

Looks good. No tests, but I added them.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ConsoleRunner/nunit-console/ConsoleOptions.cs'
2--- src/ConsoleRunner/nunit-console/ConsoleOptions.cs 2012-07-09 18:33:10 +0000
3+++ src/ConsoleRunner/nunit-console/ConsoleOptions.cs 2012-10-16 01:51:17 +0000
4@@ -73,7 +73,13 @@
5 public bool noshadow;
6
7 [Option (Description = "Disable use of a separate thread for tests")]
8- public bool nothread;
9+ public bool nothread;
10+
11+ [Option(Description = "Base path to be used when loading the assemblies")]
12+ public string basepath;
13+
14+ [Option(Description = "Additional directories to be probed when loading assemblies, separated by semicolons")]
15+ public string privatebinpath;
16
17 [Option(Description = "Set timeout for each test case in milliseconds")]
18 public int timeout;
19
20=== modified file 'src/ConsoleRunner/nunit-console/ConsoleUi.cs'
21--- src/ConsoleRunner/nunit-console/ConsoleUi.cs 2012-10-14 22:44:01 +0000
22+++ src/ConsoleRunner/nunit-console/ConsoleUi.cs 2012-10-16 01:51:17 +0000
23@@ -311,6 +311,17 @@
24 domainUsage = DomainUsage.Multiple;
25 }
26
27+ if (options.basepath != null && options.basepath != string.Empty)
28+ {
29+ package.BasePath = options.basepath;
30+ }
31+
32+ if (options.privatebinpath != null && options.privatebinpath != string.Empty)
33+ {
34+ package.AutoBinPath = false;
35+ package.PrivateBinPath = options.privatebinpath;
36+ }
37+
38 #if CLR_2_0 || CLR_4_0
39 if (options.framework != null)
40 framework = RuntimeFramework.Parse(options.framework);
41@@ -326,11 +337,10 @@
42
43 package.Settings["ProcessModel"] = processModel;
44 package.Settings["DomainUsage"] = domainUsage;
45- if (framework != null)
46+
47+ if (framework != null)
48 package.Settings["RuntimeFramework"] = framework;
49
50-
51-
52 if (domainUsage == DomainUsage.None)
53 {
54 // Make sure that addins are available

Subscribers

People subscribed via source and target branches

to status/vote changes: