Code review comment for lp:~simone.busoli/nunitv2/async-support-void-and-task-return-types
Revision history for this message
| Charlie Poole (charlie.poole) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Changes made in merging this:
1. Added nunit2012.sln alongside nunit.sln. nunit.sln doesn't have the .NET 4.5 projects.
2. Changes to the build script and conditional code to allow building the .NET 1.1 version of the code.
3. Fixed conditional compilation symbols for the two .NET 4.5 assemblies.
Still need (as separate fixes / bugs)
1. Fix RuntimeFramework class to distinguish .NET 4.5 from 4.0 as we do, for example, with 3.5 versus 2.0.
2. Add .NET 4.5 to platform attribute and mark .NET 4.5 tests to only run on that platform
3. Resolve issue with packaging: i.e. the .net 4.5 test should be included in the release package but it should not be automatically run as part of NUnitTests.nunit, since .NET 4.5 may not be installed. The uesr could install it at a later time, however.