Code review comment for lp:~simon-kersey/qbzr/590229-fix

Revision history for this message
Simon Kersey (simon-kersey) wrote :

> To clarify my point: if you keep buttons as private variables then please
> create public methods in SubProcessBase dialog to control these buttons.
> Otherwise buttons should be exposed as public variables.

I'll probably make them public variables to allow for maximum flexibilty if that is OK.
I was trying for the concept of inherited class variables (not public but available to derived classes).

« Back to merge proposal