Code review comment for lp:~simon-kersey/bzr-explorer/add-tool-cmd-selected-support

Revision history for this message
Simon Kersey (simon-kersey) wrote :

I have done some experimenting and if you run the following from a Windows command prompt:

bzr qrun add -- --dry-run "path with spaces\1 2.txt" "path with spaces\3 4.txt"

Then when the qrun dialog is displayed there are no quotes.

As for the change above, I notice that you have used %u (which seems to be an obsolete form of %d) is this for a particular reason?

I will update the code tonight. My current thoughts are to update _escape_context_items to take an additional optional parameter q which defaults to " and then to use the following as per your suggestion above:

                        escaped = [self._escape_context_item(s,"'") for s in paths]
                        self.location_context['wt_selected'] = " ".join(escaped)

« Back to merge proposal