Merge lp:~silviu.grijincu/tomatick/signals into lp:tomatick

Proposed by Silviu Grijincu
Status: Merged
Approved by: Silviu Grijincu
Approved revision: 4
Merged at revision: 4
Proposed branch: lp:~silviu.grijincu/tomatick/signals
Merge into: lp:tomatick
Diff against target: 111 lines (+27/-12)
3 files modified
src/Widgets/clock.vala (+5/-0)
src/Widgets/tasks.vala (+6/-2)
src/tomatick_window.vala (+16/-10)
To merge this branch: bzr merge lp:~silviu.grijincu/tomatick/signals
Reviewer Review Type Date Requested Status
Silviu Grijincu Approve
Review via email: mp+131736@code.launchpad.net

Description of the change

Added signals for starting and pausing the clock. Added signals for adding and removing tasks.

To post a comment you must log in.
Revision history for this message
Silviu Grijincu (silviu.grijincu) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Widgets/clock.vala'
--- src/Widgets/clock.vala 2012-10-27 13:50:13 +0000
+++ src/Widgets/clock.vala 2012-10-27 14:45:25 +0000
@@ -53,6 +53,9 @@
53 private int user_min;53 private int user_min;
54 private int user_sec;54 private int user_sec;
5555
56 public signal void clock_started();
57 public signal void clock_paused();
58
56 public ClockWidget()59 public ClockWidget()
57 {60 {
58 clock_container = new Gtk.Box(Gtk.Orientation.HORIZONTAL, 0);61 clock_container = new Gtk.Box(Gtk.Orientation.HORIZONTAL, 0);
@@ -132,6 +135,7 @@
132 launcher.urgent = true;135 launcher.urgent = true;
133 reached_zero = false;136 reached_zero = false;
134 running = true;137 running = true;
138 clock_started();
135139
136 min_buffer.changed.disconnect(apply_tags_min);140 min_buffer.changed.disconnect(apply_tags_min);
137 sec_buffer.changed.disconnect(apply_tags_sec);141 sec_buffer.changed.disconnect(apply_tags_sec);
@@ -194,6 +198,7 @@
194 time = null;198 time = null;
195 ticker = null;199 ticker = null;
196 update_ticker();200 update_ticker();
201 clock_paused();
197 }202 }
198203
199 public void reset_clock()204 public void reset_clock()
200205
=== modified file 'src/Widgets/tasks.vala'
--- src/Widgets/tasks.vala 2012-10-27 13:50:13 +0000
+++ src/Widgets/tasks.vala 2012-10-27 14:45:25 +0000
@@ -48,6 +48,9 @@
48 private TomatickWidget.FileManager file_manager;48 private TomatickWidget.FileManager file_manager;
49 private Unity.LauncherEntry launcher;49 private Unity.LauncherEntry launcher;
5050
51 public signal void task_added();
52 public signal void task_removed();
53
5154
52 public TasksWidget() {55 public TasksWidget() {
5356
@@ -109,8 +112,8 @@
109112
110 Gtk.TreeIter useless_iter;113 Gtk.TreeIter useless_iter;
111 task_list.get_iter_first (out useless_iter);114 task_list.get_iter_first (out useless_iter);
112 task_entry.activate.connect (() => { add_task (task_entry.text, useless_iter, false); });115 task_entry.activate.connect (() => { add_task (task_entry.text, useless_iter, false); task_added(); });
113 task_entry.icon_press.connect (() => { add_task (task_entry.text, useless_iter, false); });116 task_entry.icon_press.connect (() => { add_task (task_entry.text, useless_iter, false); task_added(); });
114 task_entry.backspace.connect (() => { manage_entry_backspace(); });117 task_entry.backspace.connect (() => { manage_entry_backspace(); });
115 //task_entry.key_release_event.connect (() => { add_category_style(); return true;});118 //task_entry.key_release_event.connect (() => { add_category_style(); return true;});
116119
@@ -172,6 +175,7 @@
172 update();175 update();
173 return false;176 return false;
174 });177 });
178 task_removed();
175 });179 });
176180
177 task_list.row_deleted.connect((path, iter) => { task_count--; file_manager.list_to_file_json(tree_to_json());});181 task_list.row_deleted.connect((path, iter) => { task_count--; file_manager.list_to_file_json(tree_to_json());});
178182
=== modified file 'src/tomatick_window.vala'
--- src/tomatick_window.vala 2012-10-27 13:50:13 +0000
+++ src/tomatick_window.vala 2012-10-27 14:45:25 +0000
@@ -62,10 +62,22 @@
62 clock = new TomatickWidget.ClockWidget();62 clock = new TomatickWidget.ClockWidget();
63 tasks = new TomatickWidget.TasksWidget();63 tasks = new TomatickWidget.TasksWidget();
64 stats = new TomatickWidget.StatsWidget();64 stats = new TomatickWidget.StatsWidget();
65
66 clock.clock_started.connect(() => {stdout.printf("CLOCK STARTED!\n"); label_updater();});
67 clock.clock_paused.connect(() => {stdout.printf("CLOCK PAUSED!\n"); label_updater();});
68
69 tasks.task_added.connect(() => {stdout.printf("TASK ADDED!\n"); label_updater();});
70 tasks.task_removed.connect(() => {stdout.printf("TASK REMOVED!\n");
71 label_task.set_text (label_prefix_complete + tasks.get_current_task());
72 label_task.set_use_markup (true);
73 Timeout.add (1000,() => {
74 label_updater();
75 return false;
76 });
77 });
6578
66 setup_ui();79 setup_ui();
67 tasks.update();80 tasks.update();
68 label_updater();
69 }81 }
7082
7183
@@ -73,19 +85,13 @@
73 //TODO: Should use signals85 //TODO: Should use signals
74 private void label_updater() {86 private void label_updater() {
75 string current_task = tasks.get_current_task();87 string current_task = tasks.get_current_task();
76 var time = new TimeoutSource (500);88 if (current_task == null || !clock.is_running()) {
77 time.set_callback(() => {
78 current_task = tasks.get_current_task();
79 if (current_task == null) {
80 label_task.set_text("");89 label_task.set_text("");
81 }90 }
82 else if (clock.is_running()) {91 else {
83 label_task.set_text (label_prefix_running + current_task);92 label_task.set_text (label_prefix_running + current_task);
84 label_task.set_use_markup (true);93 label_task.set_use_markup (true);
85 } 94 }
86 return true;
87 });
88 time.attach (null);
89 }95 }
9096
9197

Subscribers

People subscribed via source and target branches

to all changes: