Merge lp:~silviu.grijincu/tomatick/signals into lp:tomatick

Proposed by Silviu Grijincu
Status: Merged
Approved by: Silviu Grijincu
Approved revision: 4
Merged at revision: 4
Proposed branch: lp:~silviu.grijincu/tomatick/signals
Merge into: lp:tomatick
Diff against target: 111 lines (+27/-12)
3 files modified
src/Widgets/clock.vala (+5/-0)
src/Widgets/tasks.vala (+6/-2)
src/tomatick_window.vala (+16/-10)
To merge this branch: bzr merge lp:~silviu.grijincu/tomatick/signals
Reviewer Review Type Date Requested Status
Silviu Grijincu Approve
Review via email: mp+131736@code.launchpad.net

Description of the change

Added signals for starting and pausing the clock. Added signals for adding and removing tasks.

To post a comment you must log in.
Revision history for this message
Silviu Grijincu (silviu.grijincu) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/clock.vala'
2--- src/Widgets/clock.vala 2012-10-27 13:50:13 +0000
3+++ src/Widgets/clock.vala 2012-10-27 14:45:25 +0000
4@@ -53,6 +53,9 @@
5 private int user_min;
6 private int user_sec;
7
8+ public signal void clock_started();
9+ public signal void clock_paused();
10+
11 public ClockWidget()
12 {
13 clock_container = new Gtk.Box(Gtk.Orientation.HORIZONTAL, 0);
14@@ -132,6 +135,7 @@
15 launcher.urgent = true;
16 reached_zero = false;
17 running = true;
18+ clock_started();
19
20 min_buffer.changed.disconnect(apply_tags_min);
21 sec_buffer.changed.disconnect(apply_tags_sec);
22@@ -194,6 +198,7 @@
23 time = null;
24 ticker = null;
25 update_ticker();
26+ clock_paused();
27 }
28
29 public void reset_clock()
30
31=== modified file 'src/Widgets/tasks.vala'
32--- src/Widgets/tasks.vala 2012-10-27 13:50:13 +0000
33+++ src/Widgets/tasks.vala 2012-10-27 14:45:25 +0000
34@@ -48,6 +48,9 @@
35 private TomatickWidget.FileManager file_manager;
36 private Unity.LauncherEntry launcher;
37
38+ public signal void task_added();
39+ public signal void task_removed();
40+
41
42 public TasksWidget() {
43
44@@ -109,8 +112,8 @@
45
46 Gtk.TreeIter useless_iter;
47 task_list.get_iter_first (out useless_iter);
48- task_entry.activate.connect (() => { add_task (task_entry.text, useless_iter, false); });
49- task_entry.icon_press.connect (() => { add_task (task_entry.text, useless_iter, false); });
50+ task_entry.activate.connect (() => { add_task (task_entry.text, useless_iter, false); task_added(); });
51+ task_entry.icon_press.connect (() => { add_task (task_entry.text, useless_iter, false); task_added(); });
52 task_entry.backspace.connect (() => { manage_entry_backspace(); });
53 //task_entry.key_release_event.connect (() => { add_category_style(); return true;});
54
55@@ -172,6 +175,7 @@
56 update();
57 return false;
58 });
59+ task_removed();
60 });
61
62 task_list.row_deleted.connect((path, iter) => { task_count--; file_manager.list_to_file_json(tree_to_json());});
63
64=== modified file 'src/tomatick_window.vala'
65--- src/tomatick_window.vala 2012-10-27 13:50:13 +0000
66+++ src/tomatick_window.vala 2012-10-27 14:45:25 +0000
67@@ -62,10 +62,22 @@
68 clock = new TomatickWidget.ClockWidget();
69 tasks = new TomatickWidget.TasksWidget();
70 stats = new TomatickWidget.StatsWidget();
71+
72+ clock.clock_started.connect(() => {stdout.printf("CLOCK STARTED!\n"); label_updater();});
73+ clock.clock_paused.connect(() => {stdout.printf("CLOCK PAUSED!\n"); label_updater();});
74+
75+ tasks.task_added.connect(() => {stdout.printf("TASK ADDED!\n"); label_updater();});
76+ tasks.task_removed.connect(() => {stdout.printf("TASK REMOVED!\n");
77+ label_task.set_text (label_prefix_complete + tasks.get_current_task());
78+ label_task.set_use_markup (true);
79+ Timeout.add (1000,() => {
80+ label_updater();
81+ return false;
82+ });
83+ });
84
85 setup_ui();
86 tasks.update();
87- label_updater();
88 }
89
90
91@@ -73,19 +85,13 @@
92 //TODO: Should use signals
93 private void label_updater() {
94 string current_task = tasks.get_current_task();
95- var time = new TimeoutSource (500);
96- time.set_callback(() => {
97- current_task = tasks.get_current_task();
98- if (current_task == null) {
99+ if (current_task == null || !clock.is_running()) {
100 label_task.set_text("");
101 }
102- else if (clock.is_running()) {
103+ else {
104 label_task.set_text (label_prefix_running + current_task);
105 label_task.set_use_markup (true);
106- }
107- return true;
108- });
109- time.attach (null);
110+ }
111 }
112
113

Subscribers

People subscribed via source and target branches

to all changes: