Ubuntu
landscape-client package

Code review comment for ~silverdrake11/ubuntu/+source/landscape-client:ubuntu/mantic-devel

  1. Git
  2. lp:~silverdrake11/ubuntu/+source/landscape-client
  3. ubuntu/mantic-devel
  4. Merge into ubuntu/mantic-devel
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for addressing my comments Kevin!

Since you decided to remove the dependency on lsb-base, I think you should remove it from here as well:

https://github.com/canonical/landscape-client/blob/23.08/setup_lib.py#L21

review: Needs Fixing

« Back to merge proposal