Merge ~silverdrake11/landscape-charm:fix_install_hang2 into landscape-charm:main

[Kevin Nasto]

Fix hanging installs issue

I was able to recreate this by juju deploying several times and wait for the hang. Killing needrestart actually unblocks the install. I confirmed that all the necessary env vars are being passed to subprocess via the apt.v0 library, but still needrestart is ignoring them for some reason

[Kevin Nasto (silverdrake11)]

Note that installing needrestart again after the installs will not work, because it'll scan the processes and the popup will show again

[Bas de Bruijne (basdbruijne)]

Thanks!

review: Approve

diff --git a/src/charm.py b/src/charm.py
index c5f5c59..ad011d1 100755
--- a/src/charm.py
+++ b/src/charm.py
@@ -282,6 +282,8 @@ class LandscapeServerCharm(CharmBase):
         landscape_ppa = self.model.config["landscape_ppa"]
 
         try:
+            # This package is responsible for the hanging installs and ignores env vars
+            apt.remove_package(["needrestart"])
             # Add the Landscape Server PPA and install via apt.
             check_call(["add-apt-repository", "-y", landscape_ppa])
             apt.add_package(["landscape-server", "landscape-hashids"])