Code review comment for lp:~sil2100/unity/tests_glib_timeout_modifications

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Of course we lose some checks, but we can survive without them... However probably you can use:

Utils::WaitUntil(check_function, true, 1); instead...

53 - timeout.removed.connect([&] (unsigned int id) { clock_gettime(CLOCK_MONOTONIC, &post); });

Replace it with
timeout.removed.connect([&] (unsigned int id) { removed_called = true; });});

And check for removed_called value at the end...

« Back to merge proposal