Merge lp:~sil2100/unity-scopes-shell/packaging_review into lp:unity-scopes-shell

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 17
Merged at revision: 17
Proposed branch: lp:~sil2100/unity-scopes-shell/packaging_review
Merge into: lp:unity-scopes-shell
Diff against target: 89 lines (+20/-9)
6 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+5/-1)
debian/control (+9/-3)
debian/copyright (+2/-0)
debian/rules (+1/-4)
debian/source/format (+1/-1)
To merge this branch: bzr merge lp:~sil2100/unity-scopes-shell/packaging_review
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+195815@code.launchpad.net

Commit message

First preliminary packaging review for daily-release enablement

Description of the change

First preliminary packaging review for daily-release enablement

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

the debian/rules changes seems backward, you are going to have the --fail-missing added to other commands than dh_install, is that needed?

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems people disagree on the fail-missing use, let's not block on that...

Revision history for this message
Sebastien Bacher (seb128) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory '.bzr-builddeb'
=== added file '.bzr-builddeb/default.conf'
--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
+++ .bzr-builddeb/default.conf 2013-11-19 16:10:32 +0000
@@ -0,0 +1,2 @@
1[BUILDDEB]
2split = True
03
=== modified file 'debian/changelog'
--- debian/changelog 2013-11-13 12:43:00 +0000
+++ debian/changelog 2013-11-19 16:10:32 +0000
@@ -1,5 +1,9 @@
1unity-scopes-shell (0.1) UNRELEASED; urgency=low1unity-scopes-shell (0.1-0ubuntu1) UNRELEASED; urgency=low
22
3 [ Michal Hruby ]
3 * Initial release4 * Initial release
45
6 [ Łukasz 'sil2100' Zemczak ]
7 * Automatic snapshot from revision 16 (bootstrap)
8
5 -- Michal Hruby <michal.hruby@canonical.com> Tue, 12 Nov 2013 15:52:35 +00009 -- Michal Hruby <michal.hruby@canonical.com> Tue, 12 Nov 2013 15:52:35 +0000
610
=== modified file 'debian/control'
--- debian/control 2013-11-18 17:58:14 +0000
+++ debian/control 2013-11-19 16:10:32 +0000
@@ -11,10 +11,13 @@
11 qt5-default,11 qt5-default,
12 qtdeclarative5-dev,12 qtdeclarative5-dev,
13 qtdeclarative5-dev-tools,13 qtdeclarative5-dev-tools,
14 qtdeclarative5-qtquick2-plugin14 qtdeclarative5-qtquick2-plugin,
15Standards-Version: 3.9.415Standards-Version: 3.9.4
16Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>16Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
17Homepage: https://launchpad.net/unity-scopes-shell17Homepage: https://launchpad.net/unity-scopes-shell
18# if you don't have have commit access to this branch but would like to upload
19# directly to Ubuntu, don't worry: your changes will be merged back into the
20# upstream branch
18Vcs-Bzr: lp:unity-scopes-shell21Vcs-Bzr: lp:unity-scopes-shell
19Vcs-Browser: https://code.launchpad.net/unity-scopes-shell22Vcs-Browser: https://code.launchpad.net/unity-scopes-shell
2023
@@ -22,8 +25,11 @@
22Architecture: any25Architecture: any
23Multi-Arch: same26Multi-Arch: same
24Pre-Depends: ${misc:Pre-Depends}27Pre-Depends: ${misc:Pre-Depends}
25Depends: qtdeclarative5-dee-plugin, ${misc:Depends}, ${shlibs:Depends}28Depends: ${misc:Depends},
26Provides: unity-scopes-impl, unity-scopes-impl-029 ${shlibs:Depends},
30 qtdeclarative5-dee-plugin,
31Provides: unity-scopes-impl,
32 unity-scopes-impl-0,
27Breaks: unity8-private (<< 7.84)33Breaks: unity8-private (<< 7.84)
28Replaces: unity8-private (<< 7.84)34Replaces: unity8-private (<< 7.84)
29Description: QML plugin for Scopes35Description: QML plugin for Scopes
3036
=== modified file 'debian/copyright'
--- debian/copyright 2013-11-12 17:09:33 +0000
+++ debian/copyright 2013-11-19 16:10:32 +0000
@@ -1,4 +1,6 @@
1Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/1Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
2Upstream-Name: unity-scopes-shell
3Source: http://launchpad.net/unity-scopes-shell
24
3Files: *5Files: *
4Copyright: 2013 Canonical Ltd.6Copyright: 2013 Canonical Ltd.
57
=== modified file 'debian/rules'
--- debian/rules 2013-11-12 17:09:33 +0000
+++ debian/rules 2013-11-19 16:10:32 +0000
@@ -6,10 +6,7 @@
6export DPKG_GENSYMBOLS_CHECK_LEVEL=46export DPKG_GENSYMBOLS_CHECK_LEVEL=4
77
8%:8%:
9 dh $@ --parallel9 dh $@ --parallel --fail-missing
10
11override_dh_install:
12 dh_install --fail-missing
1310
14override_dh_auto_configure:11override_dh_auto_configure:
15 dh_auto_configure -- -DLIBDIR=/usr/lib/$(DEB_HOST_MULTIARCH)12 dh_auto_configure -- -DLIBDIR=/usr/lib/$(DEB_HOST_MULTIARCH)
1613
=== modified file 'debian/source/format'
--- debian/source/format 2013-11-12 17:09:33 +0000
+++ debian/source/format 2013-11-19 16:10:32 +0000
@@ -1,1 +1,1 @@
13.0 (native)11.0

Subscribers

People subscribed via source and target branches

to all changes: