Merge lp:~sil2100/ubuntu-themes/packaging_review into lp:ubuntu-themes

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Ken VanDine
Approved revision: 286
Merged at revision: 285
Proposed branch: lp:~sil2100/ubuntu-themes/packaging_review
Merge into: lp:ubuntu-themes
Diff against target: 101 lines (+25/-15)
3 files modified
debian/changelog (+7/-0)
debian/control (+16/-15)
debian/rules (+2/-0)
To merge this branch: bzr merge lp:~sil2100/ubuntu-themes/packaging_review
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+161687@code.launchpad.net

Commit message

Packaging changes related to compliance with our standards

Description of the change

A packaging review, as always. Just some cosmetic things - the diff is big because of some whitespace mods in the copyright - wrap-and-sort is at fault.
The copyrights seem ok. Deps as well.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
286. By Łukasz Zemczak

No need to fix copyright, too much noise is bad as well

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Better without the diff to debian/copyright, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-04-12 00:02:23 +0000
+++ debian/changelog 2013-04-30 21:07:29 +0000
@@ -1,3 +1,10 @@
1ubuntu-themes (13.04daily13.04.12-0ubuntu2) UNRELEASED; urgency=low
2
3 * debian/control, debian/rules:
4 - Changes related to compliance to our packaging standards
5
6 -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Tue, 30 Apr 2013 21:11:22 +0200
7
1ubuntu-themes (13.04daily13.04.12-0ubuntu1) raring; urgency=low8ubuntu-themes (13.04daily13.04.12-0ubuntu1) raring; urgency=low
29
3 * Automatic snapshot from revision 28310 * Automatic snapshot from revision 283
411
=== modified file 'debian/control'
--- debian/control 2013-03-11 14:46:44 +0000
+++ debian/control 2013-04-30 21:07:29 +0000
@@ -6,22 +6,23 @@
6 icon-naming-utils,6 icon-naming-utils,
7 libmagickcore5-extra,7 libmagickcore5-extra,
8 python,8 python,
9 python-rsvg,
9 python-scour,10 python-scour,
10 python-rsvg,
11Standards-Version: 3.9.311Standards-Version: 3.9.3
12Homepage: https://launchpad.net/ubuntu-themes12Homepage: https://launchpad.net/ubuntu-themes
13# If you aren't a member of ~ubuntu-art-pkg but need to upload13# If you aren't a member of ~ubuntu-art-pkg but need to upload
14# packaging changes, just go ahead. ~ubuntu-art-pkg will notice14# packaging changes, just go ahead. ~ubuntu-art-pkg will notice
15# and sync up the code again.15# and sync up the code again.
16Vcs-Bzr: https://code.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk16Vcs-Bzr: https://code.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk
17Vcs-Browser: https://bazaar.launchpad.net/~ubuntu-art-pkg/ubuntu-themes/trunk
1718
18Package: light-themes19Package: light-themes
19Architecture: all20Architecture: all
20Depends: ${misc:Depends},21Depends: gtk2-engines-murrine (>= 0.90.3+git20100810),
21 ubuntu-mono,
22 gtk2-engines-murrine (>= 0.90.3+git20100810),
23 gtk3-engines-unico (>= 1.0.1-0ubuntu2),22 gtk3-engines-unico (>= 1.0.1-0ubuntu2),
24 humanity-icon-theme23 humanity-icon-theme,
24 ubuntu-mono,
25 ${misc:Depends},
25Description: Light Themes (Ambiance and Radiance)26Description: Light Themes (Ambiance and Radiance)
26 Includes matching Ambiance and Radiance themes27 Includes matching Ambiance and Radiance themes
27 .28 .
@@ -32,30 +33,30 @@
3233
33Package: ubuntu-mono34Package: ubuntu-mono
34Architecture: all35Architecture: all
35Depends: ${misc:Depends},36Depends: gnome-icon-theme,
37 hicolor-icon-theme,
36 humanity-icon-theme,38 humanity-icon-theme,
37 gnome-icon-theme,39 ${misc:Depends},
38 hicolor-icon-theme,
39Description: Ubuntu Mono Icon theme40Description: Ubuntu Mono Icon theme
40 Dark and Light panel icons to make your desktop beautiful.41 Dark and Light panel icons to make your desktop beautiful.
4142
42Package: ubuntu-artwork43Package: ubuntu-artwork
43Architecture: all44Architecture: all
44Depends: ${misc:Depends},45Depends: adium-theme-ubuntu,
45 light-themes,46 light-themes,
46 ubuntu-mono,47 ubuntu-mono,
47 ubuntu-wallpapers,48 ubuntu-wallpapers,
48 adium-theme-ubuntu,49 ${misc:Depends},
49Description: Ubuntu themes and artwork50Description: Ubuntu themes and artwork
50 This package contains the Distributor Logo and pulls in all the51 This package contains the Distributor Logo and pulls in all the
51 other components via Depends.52 other components via Depends.
5253
53Package: ubuntu-mobile-icons54Package: ubuntu-mobile-icons
54Architecture: all55Architecture: all
55Depends: ${misc:Depends},56Depends: hicolor-icon-theme,
56 hicolor-icon-theme,57 ${misc:Depends},
57Provides: ubuntu-mobile58Provides: ubuntu-mobile,
58Conflicts: ubuntu-mobile59Conflicts: ubuntu-mobile,
59Replaces: ubuntu-mobile60Replaces: ubuntu-mobile,
60Description: Ubuntu Mobile Icon theme61Description: Ubuntu Mobile Icon theme
61 Ubuntu mobile icons used for phone and tablet applications and shell.62 Ubuntu mobile icons used for phone and tablet applications and shell.
6263
=== modified file 'debian/rules'
--- debian/rules 2012-12-11 16:50:12 +0000
+++ debian/rules 2013-04-30 21:07:29 +0000
@@ -2,6 +2,8 @@
2# Uncomment this to turn on verbose mode.2# Uncomment this to turn on verbose mode.
3#export DH_VERBOSE=13#export DH_VERBOSE=1
44
5export DPKG_GENSYMBOLS_CHECK_LEVEL=4
6
5DEB_VERSION := $(shell dpkg-parsechangelog | egrep '^Version:' | cut -f 2 -d ' ')7DEB_VERSION := $(shell dpkg-parsechangelog | egrep '^Version:' | cut -f 2 -d ' ')
68
7%:9%:

Subscribers

People subscribed via source and target branches