Code review comment for lp:~sil2100/ubuntu-keyboard/enhance_word_completion

Revision history for this message
Bill Filler (bfiller) wrote :

Getting close. There are still a few issues that need to be addressed:

For all of these tests, I just open Notes and type a new note

== turn on all the settings (spellcheck, autocomplete, word suggestions)
1) No space is entered after pressing spacebar to commit the word. For example type:
"Hey my"[spacebar]
This should produce
"Hey my " but instead produces "Hey my"
The space does not get added until you type the next word. Whenever spacebar is pressed it should commit the word and add a space.

2) Double tap on spacebar not always adding punctation:
This works correctly if there is a suggested word in the list to complete. i.e
"Hello my fri" [double tap spacebar] produces "Hello my friend. "
But if there is no suggested word, or if word suggestion/auto complete is disabled it does not work.
For example:
"Hello my uubgugugugug"[double tap spacebar] produces "Hello my uubgugugugug " while it should produce "Hello my uubgugugugug.

The rule should be double-tapping spacebar when the preceding character is not a space should always a) commit the word b) add the period + trailing space, regardless if word suggesting existed or not and regardless if word suggestion/auto-complete is enabled. This is how Android and iphone both work

review: Needs Fixing

« Back to merge proposal