Code review comment for lp:~sil2100/ubuntu-keyboard/enhance_word_completion

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

I will look now into the issue with Pinyin - currently it seems to be not working at all even (maliit-server stops due to assertion issues). In the meantime, just a quick comment related to the removal of whitespaces that I made here. The best, cleanest way would be to use preedit for those, but sadly that approach was very very troublesome. Preedit has a specific way of formatting its input. And it also interferes with the word-prediction... Since it was really really troublesome, I decided to use a more 'hacky way' for this - doing backspace actions to remove the whitespaces. It's not perfect, but it seems to be the only sane way without having to modify maliit too much.

« Back to merge proposal