Merge lp:~sil2100/ubuntu-archive-tools/plus-sign-review into lp:ubuntu-archive-tools
Proposed by
Łukasz Zemczak
Status: | Merged |
---|---|
Merged at revision: | 1114 |
Proposed branch: | lp:~sil2100/ubuntu-archive-tools/plus-sign-review |
Merge into: | lp:ubuntu-archive-tools |
Diff against target: |
33 lines (+3/-4) 1 file modified
sru-review (+3/-4) |
To merge this branch: | bzr merge lp:~sil2100/ubuntu-archive-tools/plus-sign-review |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Package Archive Administrators | Pending | ||
Review via email: mp+328449@code.launchpad.net |
Commit message
Stop urlencoding source package name in sru-review when trying to access the debdiff as it makes it impossible to review packages with + in the name.
Description of the change
Do we really need to urlencode the source package name? In the current state it just makes the script not be able to access the debdiff, e.g.:
http://
With quote() being used, the regexp cannot find the link in the queue webpage contents as the + sign is urlencoded. I wonder why this was added in the first place? Did something change in how links to the librarian are used?
To post a comment you must log in.
FWIW, the thing that changed was https:/ /code.launchpad .net/~wgrant/ launchpad/ bug-677270/ +merge/ 279974. Strictly speaking, to match that you ought to use quote(sourcepkg, safe='/~+'), but it makes no difference since there are no longer any characters that are legal in source package names and that are escaped in librarian URLs.