Code review comment for lp:~sil2100/messaging-app/flush_preedit

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

Thanks for pointing these out.
Ok, so I think the easiest way of fixing it right now is not disabling the Send button when there is no text and just indeed not send a message if there is no message present. I wonder if we need design decision regarding this? In this case I would enable it by default and do all the checks for like the sender being done on button press as well for consistency. I don't like when things work with mixed results, like button enabling/disabling for the case of number and then not doing that for the message body.

On the other hand, why do we have this check in the first place? I remember some cases where there was required to send empty messages - like for certain lotteries and contests per-SMS. Not many people per-take in those, but it's still a possible use case.

I would personally either remove the lock and enable sending empty messages out-of-the-box, or maybe think about a question dialog pop-up with a question "Do you want to send an empty sms?". I'll try the second approach, but I think design needs to comment here.

As for the OSK bug - yes, indeed it seems to be a problem. I will consider it in a separate merge for ubuntu-keyboard.

« Back to merge proposal