Merge lp:~sil2100/livecd-rootfs/bionic-core-series-per-suite into lp:~ubuntu-core-dev/livecd-rootfs/bionic-proposed

Proposed by Łukasz Zemczak
Status: Merged
Merge reported by: Steve Langasek
Merged at revision: not available
Proposed branch: lp:~sil2100/livecd-rootfs/bionic-core-series-per-suite
Merge into: lp:~ubuntu-core-dev/livecd-rootfs/bionic-proposed
Diff against target: 38 lines (+15/-1)
2 files modified
debian/changelog (+7/-1)
live-build/auto/config (+8/-0)
To merge this branch: bzr merge lp:~sil2100/livecd-rootfs/bionic-core-series-per-suite
Reviewer Review Type Date Requested Status
Simon Quigley Needs Resubmitting
Review via email: mp+357964@code.launchpad.net

Commit message

Decide what model assertion series to fetch depending on the suite. Use 16 for xenial and 18 for other series (bionic+). This enables core18 image builds. Backported from cosmic.

Description of the change

Decide what model assertion series to fetch depending on the suite. Use 16 for xenial and 18 for other series (bionic+). This enables core18 image builds. Backported from cosmic.

NOTE: Please only merge/release this once we have the core16-build support released in xenial. Currently not having this in bionic enables a window for us to build core16 images (since cosmic is core18-only).

To post a comment you must log in.
Revision history for this message
Balint Reczey (rbalint) wrote :

The target Bazaar branch is not active anymore.
Please resubmit the merge proposal against https://code.launchpad.net/~ubuntu-core-dev/livecd-rootfs/+git/livecd-rootfs/+ref/ubuntu/bionic .

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Updating the status to reflect Balint's comment.

review: Needs Resubmitting
Revision history for this message
Steve Langasek (vorlon) wrote :

this has been merged in git.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2018-10-26 21:01:17 +0000
+++ debian/changelog 2018-10-29 17:09:45 +0000
@@ -1,8 +1,14 @@
1livecd-rootfs (2.525.10) UNRELEASED; urgency=medium1livecd-rootfs (2.525.10) UNRELEASED; urgency=medium
22
3 [ Steve Langasek ]
3 * Fix Vcs-Bzr link.4 * Fix Vcs-Bzr link.
45
5 -- Steve Langasek <steve.langasek@ubuntu.com> Fri, 26 Oct 2018 15:01:07 -06006 [ Łukasz 'sil2100' Zemczak ]
7 * Decide what model assertion series to fetch depending on the suite. Use 16
8 for xenial and 18 for other series (bionic+). This enables core18 image
9 builds. Backported from cosmic.
10
11 -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@ubuntu.com> Mon, 29 Oct 2018 18:05:55 +0100
612
7livecd-rootfs (2.525.9) bionic; urgency=medium13livecd-rootfs (2.525.9) bionic; urgency=medium
814
915
=== modified file 'live-build/auto/config'
--- live-build/auto/config 2018-08-27 22:32:07 +0000
+++ live-build/auto/config 2018-10-29 17:09:45 +0000
@@ -189,6 +189,14 @@
189 UBUNTU_IMAGE_ARGS="--image-size 3700M" ;;189 UBUNTU_IMAGE_ARGS="--image-size 3700M" ;;
190 *)190 *)
191 UBUNTU_IMAGE_ARGS="" ;;191 UBUNTU_IMAGE_ARGS="" ;;
192 esac
193 case $SUITE in
194 xenial)
195 # Ubuntu Core 16
196 ;;
197 *)
198 # Ubuntu Core 18
199 MODEL="ubuntu-core-18-${MODEL#pc-}" ;;
192 esac200 esac
193201
194 echo "IMAGEFORMAT=$IMAGEFORMAT" >> config/common202 echo "IMAGEFORMAT=$IMAGEFORMAT" >> config/common

Subscribers

People subscribed via source and target branches