Merge lp:~sil2100/gnome-control-center-unity/packaging_review into lp:gnome-control-center-unity

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Ken VanDine
Approved revision: 20
Merged at revision: 19
Proposed branch: lp:~sil2100/gnome-control-center-unity/packaging_review
Merge into: lp:gnome-control-center-unity
Diff against target: 61 lines (+15/-6)
4 files modified
debian/changelog (+8/-0)
debian/control (+5/-4)
debian/rules (+2/-0)
debian/watch (+0/-2)
To merge this branch: bzr merge lp:~sil2100/gnome-control-center-unity/packaging_review
Reviewer Review Type Date Requested Status
Ken VanDine Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+161529@code.launchpad.net

Commit message

Do packaging changes related to compliance with our packaging standards

Description of the change

Do a packaging review to get gnome-control-center-unity complying to our standards. We can then transition it to head and raring.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Your changes look good, but maybe this would be a good time to remove the commented out build dep for libsocialweb-client-dev

review: Needs Fixing
20. By Łukasz Zemczak

Remove the commented out dependency

Revision history for this message
Ken VanDine (ken-vandine) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-04-09 00:01:46 +0000
+++ debian/changelog 2013-04-30 00:11:28 +0000
@@ -1,3 +1,11 @@
1gnome-control-center-unity (1.3-0ubuntu1) UNRELEASED; urgency=low
2
3 * debian/control, debian/rules:
4 - Do packaging changes related to compliance with our standards
5 * Remove debian/watch
6
7 -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Mon, 29 Apr 2013 23:40:28 +0200
8
1gnome-control-center-unity (1.2daily13.04.09-0ubuntu1) raring; urgency=low9gnome-control-center-unity (1.2daily13.04.09-0ubuntu1) raring; urgency=low
210
3 [ Sebastien Bacher ]11 [ Sebastien Bacher ]
412
=== modified file 'debian/control'
--- debian/control 2013-02-13 14:12:21 +0000
+++ debian/control 2013-04-30 00:11:28 +0000
@@ -17,17 +17,18 @@
17 libgnome-desktop-3-dev,17 libgnome-desktop-3-dev,
18 libgtk-3-dev (>= 3.5.13),18 libgtk-3-dev (>= 3.5.13),
19 libnotify-dev (>= 0.7.3),19 libnotify-dev (>= 0.7.3),
20# libsocialweb-client-dev,
21 libxml2-dev,20 libxml2-dev,
21Homepage: https://launchpad.net/gnome-control-center-unity
22# If you aren't a member of ~unity-team but need to upload packaging changes,22# If you aren't a member of ~unity-team but need to upload packaging changes,
23# just go ahead. ~unity-team will notice and sync up the code again.23# just go ahead. ~unity-team will notice and sync up the code again.
24Vcs-Bzr: http://code.launchpad.net/~unity-team/gnome-control-center-unity/trunk24Vcs-Bzr: https://code.launchpad.net/~unity-team/gnome-control-center-unity/trunk
25Vcs-Browser: https://bazaar.launchpad.net/~unity-team/gnome-control-center-unity/trunk
2526
26Package: gnome-control-center-unity27Package: gnome-control-center-unity
27Architecture: any28Architecture: any
28Depends: ${misc:Depends},29Depends: gnome-control-center,
30 ${misc:Depends},
29 ${shlibs:Depends},31 ${shlibs:Depends},
30 gnome-control-center,
31Description: change the settings of the Unity desktop32Description: change the settings of the Unity desktop
32 This package contains a settings panel for the Unity desktop,33 This package contains a settings panel for the Unity desktop,
33 allowing you to set the background and the theme.34 allowing you to set the background and the theme.
3435
=== modified file 'debian/rules'
--- debian/rules 2013-02-13 14:12:21 +0000
+++ debian/rules 2013-04-30 00:11:28 +0000
@@ -1,5 +1,7 @@
1#!/usr/bin/make -f1#!/usr/bin/make -f
22
3export DPKG_GENSYMBOLS_CHECK_LEVEL=4
4
3%:5%:
4 dh $@ --with autoreconf,translations6 dh $@ --with autoreconf,translations
57
68
=== removed file 'debian/watch'
--- debian/watch 2012-11-19 14:30:17 +0000
+++ debian/watch 1970-01-01 00:00:00 +0000
@@ -1,2 +0,0 @@
1version=3
2http://launchpad.net/gnome-control-center-unity/+download .*/gnome-control-center-unity-(.+)\.tar\.xz

Subscribers

People subscribed via source and target branches

to all changes: