Merge lp:~sil2100/cupstream2distro/skip_all_projects into lp:cupstream2distro

Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Didier Roche-Tolomelli
Proposed branch: lp:~sil2100/cupstream2distro/skip_all_projects
Merge into: lp:cupstream2distro
Diff against target: 25 lines (+2/-2)
2 files modified
cupstream2distro/packageinppa.py (+1/-1)
manual/cu2d-skip (+1/-1)
To merge this branch: bzr merge lp:~sil2100/cupstream2distro/skip_all_projects
Reviewer Review Type Date Requested Status
CU2D maintainers Pending
Review via email: mp+175884@code.launchpad.net

Commit message

Add support for ignoring all projects for a given architecture of a given stack. Now calling ./cu2d-skip stack all architecture will skip all projects in the stack for the selected architectures.

Description of the change

- Problem:

Sometimes, we'd like to force the skip of all projects in a stack for given architectures.

- Fix:

Add to cu2d-skip the functionality to skip all projects in a stack for selected architectures. This works like this:

./cu2d-skip indicators all powerpc

This will skip all projects in the indicators stack for the powerpc architecture.

This might be a bit 'risky' for some, as we're reserving the 'all' name. So, if there is a project called all in a stack, all will break down... BUT. Who would EVER accept a project like 'all' daily-releasing? It's impossible. So why not using this and making the application easy?

- Tests:

None right now. How to write some?

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I think that one isn't needed anymore for CI Train.

Unmerged revisions

356. By Łukasz Zemczak

Ok, let's simplify the architecture a bit - let's base on the assumption that a source project called 'all' will never be released (I think distro won't allow that). This way we can make everything working without even touching the jenkins jobs. Just using 'all' as the project name will cause all projects in the stack to be skipped, yay.

355. By Łukasz Zemczak

Add support for ignoring all projects for a given architecture of a given stack

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cupstream2distro/packageinppa.py'
--- cupstream2distro/packageinppa.py 2013-07-18 08:34:01 +0000
+++ cupstream2distro/packageinppa.py 2013-07-19 16:25:32 +0000
@@ -106,7 +106,7 @@
106 '''Refresh archs that we should skip for this build'''106 '''Refresh archs that we should skip for this build'''
107107
108 for arch in self.archs.copy():108 for arch in self.archs.copy():
109 if os.path.isfile("{}.{}.ignore".format(self.source_name, arch)):109 if os.path.isfile("{}.{}.ignore".format(self.source_name, arch)) or os.path.isfile("all.{}.ignore".format(arch)):
110 logging.warning("Request to ignore {} on {}.".format(self.source_name, arch))110 logging.warning("Request to ignore {} on {}.".format(self.source_name, arch))
111 try:111 try:
112 self.archs.remove(arch)112 self.archs.remove(arch)
113113
=== modified file 'manual/cu2d-skip'
--- manual/cu2d-skip 2013-04-12 11:49:18 +0000
+++ manual/cu2d-skip 2013-07-19 16:25:32 +0000
@@ -105,7 +105,7 @@
105 parser.add_argument('-d', '--debug', action='store_true', default=False,105 parser.add_argument('-d', '--debug', action='store_true', default=False,
106 help='enable debug mode')106 help='enable debug mode')
107 parser.add_argument('stack', help='Name of the stack to publish')107 parser.add_argument('stack', help='Name of the stack to publish')
108 parser.add_argument('project', help='Name of the project (source package) to skip one arch')108 parser.add_argument('project', help='Name of the project (source package) to skip one arch or \'all\' to skip all projects from the stack')
109 parser.add_argument('archs', nargs='+', help='Archs (separated by commas) to skip')109 parser.add_argument('archs', nargs='+', help='Archs (separated by commas) to skip')
110110
111 args = parser.parse_args()111 args = parser.parse_args()

Subscribers

People subscribed via source and target branches