Merge lp:~sil2100/compiz/change_scale_keybinding into lp:compiz/0.9.8

Proposed by Łukasz Zemczak on 2012-07-25
Status: Rejected
Rejected by: Daniel van Vugt on 2012-07-30
Proposed branch: lp:~sil2100/compiz/change_scale_keybinding
Merge into: lp:compiz/0.9.8
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/scale/scale.xml.in (+1/-1)
To merge this branch: bzr merge lp:~sil2100/compiz/change_scale_keybinding
Reviewer Review Type Date Requested Status
Daniel van Vugt 2012-07-25 Disapprove on 2012-07-30
Review via email: mp+116662@code.launchpad.net

Commit message

Change the default keybinding for initiating the window picker for the current workspace.

As discussed with JohnLea, this should be the default keybinding and behavior. Since we are switching to gsettings, this would be useful to change, to essentially fix the broken keybindings once and for all.

Description of the change

As discussed with JohnLea, this should be the default keybinding and behavior. Normally we had some different, undocumented keyshortcut for this. Since we are switching to gsettings, this would be useful to change, to essentially fix the broken keybindings once and for all.
This is the main reason the .convert files I submitted earlier for compiz didn't include migrations for scale keys - since we would like to actually reset the default keybindings here.

To post a comment you must log in.
Sam Spilsbury (smspillaz) wrote :

Hmm, usually we do these kinds of changes through distro patches - can we put this change there ?

Łukasz Zemczak (sil2100) wrote :

Actually, if this is how you prefer it, we can. No problem actually.

Daniel van Vugt (vanvugt) wrote :

Agreed... upstream compiz key combinations have always been different to Ubuntu/Unity, and have been largely unchanged for years. Any Ubuntu/Unity customization should be done as a distro patch in Ubuntu only.

review: Disapprove

Unmerged revisions

3293. By Łukasz Zemczak on 2012-07-25

Change the default keybinding for initiating the window picker for the current workspace.

As discussed with JohnLea, this should be the default keybinding and behavior. Since we are switching to gsettings, this would be useful to change, to essentially fix the broken keybindings once and for all.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/scale/scale.xml.in'
2--- plugins/scale/scale.xml.in 2011-09-19 13:00:51 +0000
3+++ plugins/scale/scale.xml.in 2012-07-25 14:32:24 +0000
4@@ -130,7 +130,7 @@
5 <option name="initiate_key" type="key">
6 <_short>Initiate Window Picker</_short>
7 <_long>Layout and start transforming windows</_long>
8- <default>&lt;Shift&gt;&lt;Alt&gt;Up</default>
9+ <default>&lt;Super&gt;w</default>
10 </option>
11 <option name="initiate_button" type="button">
12 <_short>Initiate Window Picker</_short>

Subscribers

People subscribed via source and target branches