Merge lp:~sil2100/biometryd/fix_ftbfs_gmock into lp:biometryd

Proposed by Łukasz Zemczak
Status: Needs review
Proposed branch: lp:~sil2100/biometryd/fix_ftbfs_gmock
Merge into: lp:biometryd
Diff against target: 41 lines (+4/-9)
2 files modified
debian/control (+1/-0)
tests/CMakeLists.txt (+3/-9)
To merge this branch: bzr merge lp:~sil2100/biometryd/fix_ftbfs_gmock
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+322118@code.launchpad.net

Commit message

Switch to using cmake-extras for gmock and gtest.

Description of the change

Work in progress! First try on fixing the gmock related build failure.

To post a comment you must log in.
44. By Łukasz Zemczak

The leftover add_subdirectory of gmock makes CMake still bail out. Thanks to Pete Woods\!

Unmerged revisions

44. By Łukasz Zemczak

The leftover add_subdirectory of gmock makes CMake still bail out. Thanks to Pete Woods\!

43. By Łukasz Zemczak

First try on fixing the gmock related build failure.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2016-09-22 16:56:34 +0000
+++ debian/control 2017-04-06 16:09:43 +0000
@@ -7,6 +7,7 @@
7Priority: optional7Priority: optional
8Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>8Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
9Build-Depends: cmake,9Build-Depends: cmake,
10 cmake-extras,
10 debhelper (>= 9),11 debhelper (>= 9),
11 doxygen,12 doxygen,
12 google-mock,13 google-mock,
1314
=== modified file 'tests/CMakeLists.txt'
--- tests/CMakeLists.txt 2016-09-22 16:56:34 +0000
+++ tests/CMakeLists.txt 2017-04-06 16:09:43 +0000
@@ -6,11 +6,7 @@
6configure_file(config.cpp.in config.cpp)6configure_file(config.cpp.in config.cpp)
7include_directories(.)7include_directories(.)
8# Build with system gmock and embedded gtest8# Build with system gmock and embedded gtest
9set (GMOCK_INCLUDE_DIR "/usr/include/gmock/include" CACHE PATH "gmock source include directory")9find_package(GMock)
10set (GMOCK_SOURCE_DIR "/usr/src/gmock" CACHE PATH "gmock source directory")
11set (GTEST_INCLUDE_DIR "${GMOCK_SOURCE_DIR}/gtest/include" CACHE PATH "gtest source include directory")
12
13add_subdirectory(${GMOCK_SOURCE_DIR} "${CMAKE_CURRENT_BINARY_DIR}/gmock")
1410
15# Ensure that we have a ready-made fixture maintaining a private bus instance11# Ensure that we have a ready-made fixture maintaining a private bus instance
16# readily available in unit- and integration tests.12# readily available in unit- and integration tests.
@@ -38,10 +34,8 @@
3834
39 ${ARGN}35 ${ARGN}
4036
41 gmock37 ${GMOCK_LIBRARIES}
4238 ${GTEST_BOTH_LIBRARIES})
43 gtest
44 gtest_main)
4539
46 add_test(${test_name} ${CMAKE_CURRENT_BINARY_DIR}/${test_name} --gtest_filter=*-*requires*)40 add_test(${test_name} ${CMAKE_CURRENT_BINARY_DIR}/${test_name} --gtest_filter=*-*requires*)
47 set_tests_properties(${test_name} PROPERTIES ENVIRONMENT "BIOMETRYD_DBUS_SKELETON_IS_RUNNING_UNDER_TESTING=1")41 set_tests_properties(${test_name} PROPERTIES ENVIRONMENT "BIOMETRYD_DBUS_SKELETON_IS_RUNNING_UNDER_TESTING=1")

Subscribers

People subscribed via source and target branches