Merge lp:~sil2100/address-book-service/packaging_review into lp:address-book-service

Proposed by Łukasz Zemczak
Status: Rejected
Rejected by: Renato Araujo Oliveira Filho
Proposed branch: lp:~sil2100/address-book-service/packaging_review
Merge into: lp:address-book-service
Diff against target: 57 lines (+18/-7)
2 files modified
debian/changelog (+9/-2)
debian/control (+9/-5)
To merge this branch: bzr merge lp:~sil2100/address-book-service/packaging_review
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+167812@code.launchpad.net

Commit message

Rename source package to address-book-service. Modifications related to compliance with our packaging standards

Description of the change

Packaging review. Modifications related to compliance with our packaging standards. Rename source package to address-book-service, since it makes no sense to have a different name than the LP project name.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Perhaps the binary should be renamed too?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

this should be renamed:

52 +Depends: galera-contact-service (= ${source:Version}),

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Perhaps the binary should be renamed too?

I will rename the binary in a new MR.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

you will need to rename the ".install" file too.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-06-05 21:22:37 +0000
+++ debian/changelog 2013-06-06 17:02:25 +0000
@@ -1,5 +1,12 @@
1galera-contact-service (0.1.0) saucy; urgency=low1address-book-service (0.1.0-0ubuntu1) UNRELEASED; urgency=low
22
3 [ Renato Araujo Oliveira Filho ]
3 * Initial release.4 * Initial release.
45
5 -- Renato Araujo Oliveira Filho <renato@canonical.com> Wed, 05 Jun 2013 15:13:34 -03006 [ Łukasz 'sil2100' Zemczak ]
7 * debian/control:
8 - Modifications related to compliance with our packaging standards
9 * Change source package name to address-book-service
10 * Automatic snapshot from revision 23 (bootstrap)
11
12 -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Thu, 06 Jun 2013 18:48:25 +0200
613
=== modified file 'debian/control'
--- debian/control 2013-06-05 21:22:37 +0000
+++ debian/control 2013-06-06 17:02:25 +0000
@@ -1,16 +1,20 @@
1Source: galera-contact-service1Source: address-book-service
2Section: utils2Section: utils
3Priority: optional3Priority: optional
4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5Build-Depends: cmake (>= 2.8.9),5Build-Depends: cmake (>= 2.8.9),
6 debhelper (>= 9),6 debhelper (>= 9),
7 libfolks-dev,
7 qt5-default,8 qt5-default,
8 qt5-qmake,9 qt5-qmake,
9 qtbase5-dev,10 qtbase5-dev,
10 qtpim5-dev,11 qtpim5-dev,
11 libfolks-dev,
12Standards-Version: 3.9.412Standards-Version: 3.9.4
13Vcs-Bzr: lp:~phablet-team/address-book-service/trunk13Homepage: https://launchpad.net/address-book-service
14# If you aren't a member of ~phablet-team but need to upload packaging changes,
15# just go ahead. ~phablet-team will notice and sync up the code again.
16Vcs-Bzr: https://code.launchpad.net/~phablet-team/address-book-service/trunk
17Vcs-Browser: http://bazaar.launchpad.net/~phablet-team/address-book-service/trunk/files
1418
15Package: galera-contact-service19Package: galera-contact-service
16Architecture: any20Architecture: any
@@ -21,8 +25,8 @@
2125
22Package: qtcontact5-galera26Package: qtcontact5-galera
23Architecture: any27Architecture: any
24Depends: ${misc:Depends},28Depends: galera-contact-service (= ${source:Version}),
29 ${misc:Depends},
25 ${shlibs:Depends},30 ${shlibs:Depends},
26 galera-contact-service (= ${source:Version}),
27Description: QtContacts backend for galera contact service.31Description: QtContacts backend for galera contact service.
28 A QContactEngine implementation using galera contact service.32 A QContactEngine implementation using galera contact service.

Subscribers

People subscribed via source and target branches